Conversation
github-actions
bot
added
10.rebuild-darwin: 1
|
I genuinely don't understand the value of this package. This isn't anything executable and we only do I really hope there's a good explanation, because otherwise I'll drop it over in #379542 because it has a sodium-native.node in its closure that wrongly requires an executable stack and I'm not going to patch behind questionable stuff like this. |
|
Yes, the reasoning behind packaging this and other similar components is explained in this comment, which was perhaps a bit too hopeful at the time. I agree with you that these libraries aren't providing any value at the moment and we haven't gotten to making them work together, so feel free to drop it if you think that's the best course of action. We can re-introduce them later after we figure out how to properly compose them (if that's even needed at all). Here are the other packages from the same project (
|
This has a sodium-native.node with a wrongly set executable bit. Now, instead of patching it, I'll just drop it because it's not a real program, but a Node library. We use `buildNpm*` for that purpose. This only makes maintenance harder because issues like this are non-trivial to spot! Related: NixOS#403638 (comment)
This has a sodium-native.node with a wrongly set executable bit. Now, instead of patching it, I'll just drop it because it's not a real program, but a Node library. We use `buildNpm*` for that purpose. This only makes maintenance harder because issues like this are non-trivial to spot! Related: NixOS#403638 (comment)
This has a sodium-native.node with a wrongly set executable bit. Now, instead of patching it, I'll just drop it because it's not a real program, but a Node library. We use `buildNpm*` for that purpose. This only makes maintenance harder because issues like this are non-trivial to spot! Related: NixOS#403638 (comment)
This has a sodium-native.node with a wrongly set executable bit. Now, instead of patching it, I'll just drop it because it's not a real program, but a Node library. We use `buildNpm*` for that purpose. This only makes maintenance harder because issues like this are non-trivial to spot! Related: NixOS#403638 (comment)
5 participants
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.