Conversation
|
Jobset: https://hydra.nixos.org/jobset/nixpkgs/glibc-2.41 Linux stdenvs for now, afterwards I expect all of x86_64-linux. Given the previous experience, I assume that you chose a commit base that's known to be not too broken. |
|
A thread of interest: https://sourceware.org/bugzilla/show_bug.cgi?id=32653 |
fabianhjr
left a comment
There was a problem hiding this comment.
Should probably skip this release, there is likely to be a more backwards compatible release in the near future.
|
|
|
|
|
Will need a 2a9a83e revert: |
|
It was precisely the intention to not forget about this here by having a build failure when rebasing again. |
|
Planning to catch 25.11? If so, there are |
|
One week, only about one week left. |
|
So, after fixing GCC there's quite a lot of stuff building again. I'll need to take a look at how to deal with the exec-stack problem this weekend, then I can make a suggestion. |
Failing Hydra build: https://hydra.nixos.org/build/308304933 ChangeLog: https://chuck.stanford.edu/release/VERSIONS
Failing Hydra build: https://hydra.nixos.org/build/308374102 Considering how old this package seems to be according to the changelog[1], I'm not going to bother with patching it. [1] https://metadata.ftp-master.debian.org/changelogs//main/x/xxgdb/xxgdb_1.12-17_changelog
Failing Hydra build: https://hydra.nixos.org/build/308340445
Failing Hydra build: https://hydra.nixos.org/build/308527220
To fix build with glibc-2.42. Failing Hydra build: https://hydra.nixos.org/build/308474067
Failing Hydra build: https://hydra.nixos.org/build/308467284
Failing Hydra build: https://hydra.nixos.org/build/308527236 Compat is being worked on, but the patch for glibc 2.42 seems to crash at runtime.
Failing Hydra build: https://hydra.nixos.org/build/308526977 I'm not sure what exactly caused the failure here, but this patch from LLVM upstream seems to fix the problem and this regressed right after the glibc upgrade.
Failing Hydra build: https://hydra.nixos.org/build/308650242 The libraries require an execstack even though it's not necessary. This got fixed upstream already[1], but this doesn't apply cleanly on the version we have. [1] microsoft/onnxruntime#25200
Doesn't build with glibc-2.42 anymore, didn't see a release in 10 years. Failing Hydra build: https://hydra.nixos.org/build/308670849
Failing Hydra build: https://hydra.nixos.org/build/317772107
Failing Hydra build: https://hydra.nixos.org/build/317799900 This turns of a warning about a potential format overflow, but I consider it sufficiently unlikely to have enough threads[1] such that this actually causes an overflow. [1] https://git.kernel.org/pub/scm/utils/rt-tests/rt-tests.git/tree/src/pmqtest/pmqtest.c#n546
|
OK, so I managed to rebuild my laptop's configuration on this branch and can boot into a system built with glibc 2.42. I'd say we're good to go now. The Hydra jobset is looking quite good (and most jobs are fallout of uvloop's flaky tests anyways). There's even documentation about the execstack topic now. I'm considering to add a dedicated glibc-shenanigans section to the nixpkgs manual which will also include the execstack part, but I think we're good with the release-notes section I added. Reviews would be very welcome. |
|
It sounds good to me. Also, the executable stack thing is almost one year released upstream, so that's quite some time for other SW to adapt (at least from Nixpkgs perspective of short release cycles). |
|
Also, more fixes could be done during |
fabianhjr
left a comment
There was a problem hiding this comment.
Only regarding glibc changes (didn't review package fixes/removals)
Would prefer removals not to be included in this PR but wouldn't oppose for this to be merged as is either and any issues being addressed during staging/staging-next cycles.
|
The packages removed in here are an intersection of
Everything else is either fixed or marked as broken (or missed while checking Hydra). |
Announcement: https://lists.gnu.org/archive/html/info-gnu/2025-01/msg00014.html
Build-wise it's looking relatively good and I got quite far.
However, I'm a little worried about
Let's see how many regressions Hydra can find regarding that. But I'll need to look for more bugreports on that matter for potential fallout.
TODO:
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.