Conversation
|
(in answer to #405245 (comment)) I agree I'll remove the label and request review from other some committers who are free to merge if they think my impression is in alignment with nixpkgs. |
|
we have go-ahead from release manager https://matrix.to/#/!aGqRytqbCECitOFhbt:nixos.org/$iaGbD7s9QFxLOa80Pb4d643uRQ2JTos7tfHePZAQ2tI?via=nixos.org&via=matrix.org&via=tchncs.de |
|
Looks like this broke evaluation |
|
Uh oh - seems #401206 (comment) was never cleaned up, i wonder how i missed that... |
|
CI should have caught it, but it seems it was evaluated with allowaliases? |
It was cleaned up but was mistakenly reintroduced by #405640 |
|
okay what the hell... Why was that reintroduced? Was darwin actually broken? |
|
Seems to be my fault, I should have caught the |
|
Eh, its fine, lets not play the blame game here - this happened, now we need to clean up the mess. Do we have anyone with a darwin builder on the new sdl team? |
|
Retrospectives are not IMO to assign blame, but to prevent future cases like it :)
Consider https://nix-community.org/community-builders/, it is what i use. You two getting access should IMO not be an issue |
No longer needed after #402066
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.