Skip to content

SDL2{,_classic}_mixer_2_0: drop#402279

Merged
pbsds merged 1 commit intoNixOS:masterfrom
marcin-serwin:push-przlltvyynyv
May 14, 2025
Merged

SDL2{,_classic}_mixer_2_0: drop#402279
pbsds merged 1 commit intoNixOS:masterfrom
marcin-serwin:push-przlltvyynyv

Conversation

@marcin-serwin
Copy link
Contributor

No longer needed after #402066

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@marcin-serwin marcin-serwin added the 2.status: wait for branch‐off Waiting for the next Nixpkgs branch‐off label Apr 27, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 27, 2025
@LordGrimmauld LordGrimmauld self-requested a review April 27, 2025 13:49
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 27, 2025
@LordGrimmauld LordGrimmauld mentioned this pull request May 14, 2025
28 tasks
@pbsds
Copy link
Member

pbsds commented May 14, 2025

(in answer to #405245 (comment))

I agree wait for branch-off may not apply, since I don't think dropping a temporary pinned package version count as a breaking change.

I'll remove the label and request review from other some committers who are free to merge if they think my impression is in alignment with nixpkgs.

@pbsds pbsds removed the 2.status: wait for branch‐off Waiting for the next Nixpkgs branch‐off label May 14, 2025
@pbsds
Copy link
Member

pbsds commented May 14, 2025

@pbsds pbsds merged commit 0c54ab2 into NixOS:master May 14, 2025
29 checks passed
@niklaskorz
Copy link
Member

Looks like this broke evaluation

@LordGrimmauld
Copy link
Contributor

Uh oh - seems #401206 (comment) was never cleaned up, i wonder how i missed that...

@pbsds
Copy link
Member

pbsds commented May 14, 2025

CI should have caught it, but it seems it was evaluated with allowaliases?

@marcin-serwin
Copy link
Contributor Author

Uh oh - seems #401206 (comment) was never cleaned up, i wonder how i missed that...

It was cleaned up but was mistakenly reintroduced by #405640

@LordGrimmauld
Copy link
Contributor

okay what the hell... Why was that reintroduced? Was darwin actually broken?

@pbsds
Copy link
Member

pbsds commented May 14, 2025

Seems to be my fault, I should have caught the _2_0 addition in there

@LordGrimmauld
Copy link
Contributor

Eh, its fine, lets not play the blame game here - this happened, now we need to clean up the mess. Do we have anyone with a darwin builder on the new sdl team?

@pbsds pbsds mentioned this pull request May 14, 2025
13 tasks
@pbsds
Copy link
Member

pbsds commented May 14, 2025

Retrospectives are not IMO to assign blame, but to prevent future cases like it :)

Do we have anyone with a darwin builder on the new sdl team?

Consider https://nix-community.org/community-builders/, it is what i use. You two getting access should IMO not be an issue

@marcin-serwin marcin-serwin deleted the push-przlltvyynyv branch June 23, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants