Skip to content

SDL2{,_classic}_mixer_2_0: drop#407073

Merged
Mic92 merged 2 commits intoNixOS:masterfrom
pbsds:drop-SDL2_classic_mixer_2_0-1747240775
May 14, 2025
Merged

SDL2{,_classic}_mixer_2_0: drop#407073
Mic92 merged 2 commits intoNixOS:masterfrom
pbsds:drop-SDL2_classic_mixer_2_0-1747240775

Conversation

@pbsds
Copy link
Member

@pbsds pbsds commented May 14, 2025

retry of #402279

  • SDL2{,_classic}_mixer_2_0: drop
  • python313Packages.pygame-ce: unpin SDL_classic_mixer again

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label May 14, 2025
@Mic92 Mic92 mentioned this pull request May 14, 2025
13 tasks
@pbsds pbsds mentioned this pull request May 14, 2025
13 tasks
Copy link
Contributor

@LordGrimmauld LordGrimmauld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we flip the commit order so eval isn't intermittently broken?

@pbsds pbsds force-pushed the drop-SDL2_classic_mixer_2_0-1747240775 branch from 89f206a to 94bce7d Compare May 14, 2025 16:51
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 14, 2025
@pbsds
Copy link
Member Author

pbsds commented May 14, 2025

  • tested pygame-ce build on aarch64-darwin, and full eval with nix-env

@Mic92
Copy link
Member

Mic92 commented May 14, 2025

Those need a rebase: #407061 #407064 after merging.

@pbsds
Copy link
Member Author

pbsds commented May 14, 2025

Those need a rebase: #407061 #407064 after merging.

thanks, will do

Copy link
Contributor

@LordGrimmauld LordGrimmauld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff looks fine now, though i can't test darwin

@Mic92
Copy link
Member

Mic92 commented May 14, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 407073


x86_64-linux

✅ 8 packages built:
  • python312Packages.pygame-ce
  • python312Packages.pygame-ce.dist
  • python312Packages.pygame-gui
  • python312Packages.pygame-gui.dist
  • python313Packages.pygame-ce
  • python313Packages.pygame-ce.dist
  • python313Packages.pygame-gui
  • python313Packages.pygame-gui.dist

aarch64-linux

✅ 8 packages built:
  • python312Packages.pygame-ce
  • python312Packages.pygame-ce.dist
  • python312Packages.pygame-gui
  • python312Packages.pygame-gui.dist
  • python313Packages.pygame-ce
  • python313Packages.pygame-ce.dist
  • python313Packages.pygame-gui
  • python313Packages.pygame-gui.dist

x86_64-darwin

✅ 8 packages built:
  • python312Packages.pygame-ce
  • python312Packages.pygame-ce.dist
  • python312Packages.pygame-gui
  • python312Packages.pygame-gui.dist
  • python313Packages.pygame-ce
  • python313Packages.pygame-ce.dist
  • python313Packages.pygame-gui
  • python313Packages.pygame-gui.dist

aarch64-darwin

✅ 8 packages built:
  • python312Packages.pygame-ce
  • python312Packages.pygame-ce.dist
  • python312Packages.pygame-gui
  • python312Packages.pygame-gui.dist
  • python313Packages.pygame-ce
  • python313Packages.pygame-ce.dist
  • python313Packages.pygame-gui
  • python313Packages.pygame-gui.dist

@Mic92 Mic92 merged commit 060440c into NixOS:master May 14, 2025
23 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants