Skip to content

python3Packages.pygame-ce: unbreak on darwin again#405640

Merged
pbsds merged 1 commit intoNixOS:masterfrom
Rhys-T:fix-pygame-ce-darwin-again
May 9, 2025
Merged

python3Packages.pygame-ce: unbreak on darwin again#405640
pbsds merged 1 commit intoNixOS:masterfrom
Rhys-T:fix-pygame-ce-darwin-again

Conversation

@Rhys-T
Copy link
Contributor

@Rhys-T Rhys-T commented May 9, 2025

Originally fixed in 66ebd9e from #401206, but it seems to have been lost in c8c30c9.

ZHF: #403336

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Originally fixed in 66ebd9e, but it
seems to have been lost in c8c30c9.
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 9, 2025
@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 9, 2025
@nix-owners nix-owners bot requested a review from pbsds May 9, 2025 16:37
@pbsds
Copy link
Member

pbsds commented May 9, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 405640


x86_64-linux

✅ 8 packages built:
  • python312Packages.pygame-ce
  • python312Packages.pygame-ce.dist
  • python312Packages.pygame-gui
  • python312Packages.pygame-gui.dist
  • python313Packages.pygame-ce
  • python313Packages.pygame-ce.dist
  • python313Packages.pygame-gui
  • python313Packages.pygame-gui.dist

aarch64-linux

✅ 8 packages built:
  • python312Packages.pygame-ce
  • python312Packages.pygame-ce.dist
  • python312Packages.pygame-gui
  • python312Packages.pygame-gui.dist
  • python313Packages.pygame-ce
  • python313Packages.pygame-ce.dist
  • python313Packages.pygame-gui
  • python313Packages.pygame-gui.dist

x86_64-darwin

✅ 8 packages built:
  • python312Packages.pygame-ce
  • python312Packages.pygame-ce.dist
  • python312Packages.pygame-gui
  • python312Packages.pygame-gui.dist
  • python313Packages.pygame-ce
  • python313Packages.pygame-ce.dist
  • python313Packages.pygame-gui
  • python313Packages.pygame-gui.dist

aarch64-darwin

✅ 8 packages built:
  • python312Packages.pygame-ce
  • python312Packages.pygame-ce.dist
  • python312Packages.pygame-gui
  • python312Packages.pygame-gui.dist
  • python313Packages.pygame-ce
  • python313Packages.pygame-ce.dist
  • python313Packages.pygame-gui
  • python313Packages.pygame-gui.dist

@pbsds
Copy link
Member

pbsds commented May 9, 2025

cc @K900, just for awareness
I've gotten confused during many merges myself

@pbsds pbsds merged commit 551becc into NixOS:master May 9, 2025
35 of 36 checks passed
Rhys-T added a commit to Rhys-T/nur-packages that referenced this pull request May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants