Skip to content

darwin: move deprecated packages to aliases#400646

Merged
emilazy merged 4 commits intoNixOS:stagingfrom
emilazy:push-qvtlnonkpsus
Apr 23, 2025
Merged

darwin: move deprecated packages to aliases#400646
emilazy merged 4 commits intoNixOS:stagingfrom
emilazy:push-qvtlnonkpsus

Conversation

@emilazy
Copy link
Member

@emilazy emilazy commented Apr 21, 2025

Depends on #399609, #399630, #400402, #400424, and #400427.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@emilazy emilazy requested a review from a team April 21, 2025 21:28
@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Apr 21, 2025
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Apr 21, 2025
@emilazy emilazy force-pushed the push-qvtlnonkpsus branch from d867c36 to 20fae41 Compare April 21, 2025 22:03
Copy link
Contributor

@reckenrode reckenrode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 23, 2025
@emilazy emilazy force-pushed the push-qvtlnonkpsus branch 2 times, most recently from 25cb969 to 923f331 Compare April 23, 2025 16:11
emilazy added 4 commits April 23, 2025 17:29
This has been broken on Darwin since 2020 and depends on deprecated
stubs. Best to remove it until someone figures out how to get it
working again than spend effort tidying up dead code.
@emilazy emilazy force-pushed the push-qvtlnonkpsus branch from 923f331 to 09d5e1a Compare April 23, 2025 16:29
@github-actions github-actions bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 23, 2025
@nix-owners nix-owners bot requested a review from edolstra April 23, 2025 16:38
@emilazy
Copy link
Member Author

emilazy commented Apr 23, 2025

CI is green; merging 🎉

@emilazy emilazy merged commit b421685 into NixOS:staging Apr 23, 2025
23 of 27 checks passed
@emilazy emilazy deleted the push-qvtlnonkpsus branch April 23, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants