treewide: remove references to deprecated darwin.libobjc stub#400402
Merged
emilazy merged 1 commit intoNixOS:stagingfrom Apr 22, 2025
Merged
treewide: remove references to deprecated darwin.libobjc stub#400402emilazy merged 1 commit intoNixOS:stagingfrom
darwin.libobjc stub#400402emilazy merged 1 commit intoNixOS:stagingfrom
Conversation
github-actions
bot
added
6.topic: haskell
nix-owners
bot
requested review from
RaghavSood,
jbedo,
maralorn,
mmahut,
sternenseemann and
wolfgangwalther
github-actions
bot
added
10.rebuild-darwin: 5001+
emilazy
force-pushed
the
push-szwzxwkmvlpt
branch
from
08d9458 to
9152208
Compare
Comment on lines
167
to
171
Contributor
There was a problem hiding this comment.
The whole FractalArt = ... can now go away.
Member
Author
There was a problem hiding this comment.
Thanks; the script is too naive to handle that. Done manually.
This was done with booxter’s fantastic [nix-clean-apple_sdk] tool, simply modified to look for `libobjc` rather than the existing list he already used in <NixOS#398707>. Some manual work was applied, including cleaning up a string interpolation in the terrifying MacVim derivation, stray comments, empty lists, function parameters, and `inherit`s, including all of the references in `all-packages.nix`. [nix-clean-apple_sdk]: https://github.com/booxter/nix-clean-apple_sdk
emilazy
force-pushed
the
push-szwzxwkmvlpt
branch
from
9152208 to
954bb3b
Compare
13 tasks
reckenrode
approved these changes
Apr 22, 2025
Contributor
reckenrode
left a comment
reckenrode
left a comment
There was a problem hiding this comment.
LGTM. The packages that are adding libresolv shouldn’t need to do that. Darwin provides libresolv in the SDK (and did even prior to the rework). Fixing that is out of scope for this PR though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was done with @booxter’s fantastic nix-clean-apple_sdk tool, simply modified to look for
libobjcrather than the existing list he already used in #398707. Some manual work was applied, including cleaning up a string interpolation in the terrifying MacVim derivation, stray comments, empty lists, function parameters, andinherits, including all of the references inall-packages.nix.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.