Skip to content

nextpnr: 0.7.0 -> 0.8.0#399630

Merged
emilazy merged 1 commit intoNixOS:masterfrom
booxter:nextpnr-bump-darwin-fix
Apr 21, 2025
Merged

nextpnr: 0.7.0 -> 0.8.0#399630
emilazy merged 1 commit intoNixOS:masterfrom
booxter:nextpnr-bump-darwin-fix

Conversation

@booxter
Copy link
Contributor

@booxter booxter commented Apr 18, 2025

This bump fixes darwin build, among other things.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@booxter booxter force-pushed the nextpnr-bump-darwin-fix branch from cbd7597 to 4c6d886 Compare April 18, 2025 01:25
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 18, 2025
@nix-owners nix-owners bot requested a review from thoughtpolice April 18, 2025 01:33
This bump fixes darwin build, among other things.

Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
@booxter
Copy link
Contributor Author

booxter commented Apr 18, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 399630


aarch64-darwin

❌ 2 packages failed to build:
  • glasgow
  • glasgow.dist
✅ 2 packages built:
  • nextpnr
  • nextpnrWithGui

@thoughtpolice
Copy link
Member

LGTM, but what was the build failure for glasgow about?

@booxter
Copy link
Contributor Author

booxter commented Apr 18, 2025

The glasgow failure is because sdcc which is its dependency is broken for Darwin since the bump to 4.5.0. (Apparently it doesn't install man pages, which breaks the man output for the derivation.) So not related.

hydra-check sdcc --arch aarch64-darwin
Build Status for sdcc.aarch64-darwin on jobset nixpkgs/trunk
https://hydra.nixos.org/job/nixpkgs/trunk/sdcc.aarch64-darwin
✖ (Failed)  sdcc-4.5.0  2025-04-18  https://hydra.nixos.org/build/294924414
✖ (Failed)  sdcc-4.5.0  2025-04-11  https://hydra.nixos.org/build/294660615
✖ (Failed)  sdcc-4.5.0  2025-04-03  https://hydra.nixos.org/build/293335728
✖ (Failed)  sdcc-4.5.0  2025-03-13  https://hydra.nixos.org/build/292248825
✖ (Failed)  sdcc-4.5.0  2025-02-23  https://hydra.nixos.org/build/290550904
✖ (Failed)  sdcc-4.5.0  2025-02-07  https://hydra.nixos.org/build/288039863
✖ (Failed)  sdcc-4.5.0  2025-01-29  https://hydra.nixos.org/build/287247776
✔           sdcc-4.4.0  2025-01-20  https://hydra.nixos.org/build/285825661
✔           sdcc-4.4.0  2024-12-23  https://hydra.nixos.org/build/282807142
✔           sdcc-4.4.0  2024-12-03  https://hydra.nixos.org/build/280936895

I will hold this PR as draft until I run nixpkgs-review for linux.

@booxter booxter marked this pull request as draft April 18, 2025 20:37
@booxter
Copy link
Contributor Author

booxter commented Apr 19, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 399630


x86_64-linux

✅ 4 packages built:
  • glasgow
  • glasgow.dist
  • nextpnr
  • nextpnrWithGui

@booxter booxter marked this pull request as ready for review April 19, 2025 00:33
@booxter
Copy link
Contributor Author

booxter commented Apr 19, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 399630


aarch64-linux

✅ 4 packages built:
  • glasgow
  • glasgow.dist
  • nextpnr
  • nextpnrWithGui

x86_64-darwin

❌ 2 packages failed to build:
  • glasgow
  • glasgow.dist
✅ 2 packages built:
  • nextpnr
  • nextpnrWithGui

@booxter
Copy link
Contributor Author

booxter commented Apr 19, 2025

Confirmed all green for Linux and the same issue with sdcc on Darwin that is not related to this patch.

@wegank wegank added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. 12.approvals: 1 This PR was reviewed and approved by one person. labels Apr 19, 2025
@emilazy emilazy merged commit 8f256d7 into NixOS:master Apr 21, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants