Skip to content

doc: cleanup#400164

Merged
Aleksanaa merged 6 commits intoNixOS:masterfrom
drupol:push-kvvztlstmqlv
Apr 21, 2025
Merged

doc: cleanup#400164
Aleksanaa merged 6 commits intoNixOS:masterfrom
drupol:push-kvvztlstmqlv

Conversation

@drupol
Copy link
Contributor

@drupol drupol commented Apr 19, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: agda A dependently typed programming language / interactive theorem prover 6.topic: java Including JDK, tooling, other languages, other VMs 8.has: documentation This PR adds or changes documentation labels Apr 19, 2025
@drupol drupol force-pushed the push-kvvztlstmqlv branch from e23b425 to 66bd1d7 Compare April 19, 2025 20:21
@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Apr 19, 2025
@nix-owners nix-owners bot requested a review from SuperSandro2000 April 19, 2025 20:29
@drupol
Copy link
Contributor Author

drupol commented Apr 19, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 400164 --package nixpkgs-manual --package nixpkgs-manual.passthru.tests.check-nix-code-blocks

x86_64-linux

✅ 2 packages built:
  • nixpkgs-manual
  • nixpkgs-manual.passthru.tests.check-nix-code-blocks

@drupol drupol force-pushed the push-kvvztlstmqlv branch 2 times, most recently from 0169a91 to 49fdf54 Compare April 19, 2025 20:44
0xda157
0xda157 suggested changes Apr 19, 2025
View reviewed changes
Copy link
Contributor

@0xda157 0xda157 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are some places where version needs to replaced with finalAttrs.version

@drupol
Copy link
Contributor Author

drupol commented Apr 19, 2025

there are some places where version needs to replaced with finalAttrs.version

Do you remember where you saw that?

0xda157
0xda157 reviewed Apr 19, 2025
View reviewed changes
@drupol drupol force-pushed the push-kvvztlstmqlv branch from 49fdf54 to 70beb89 Compare April 19, 2025 21:33
@github-actions github-actions bot added 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. labels Apr 19, 2025
@drupol drupol force-pushed the push-kvvztlstmqlv branch 4 times, most recently from 898bd9d to b18e55b Compare April 19, 2025 21:52
0xda157
0xda157 reviewed Apr 19, 2025
View reviewed changes
@drupol drupol force-pushed the push-kvvztlstmqlv branch from b18e55b to 6186e86 Compare April 19, 2025 22:04
0xda157
0xda157 reviewed Apr 19, 2025
View reviewed changes
@drupol drupol force-pushed the push-kvvztlstmqlv branch from 6186e86 to d37c43c Compare April 20, 2025 16:36
@drupol drupol requested a review from fricklerhandwerk April 20, 2025 16:37
0xda157
0xda157 reviewed Apr 20, 2025
View reviewed changes
@drupol drupol force-pushed the push-kvvztlstmqlv branch 3 times, most recently from 95587bc to b727b0f Compare April 20, 2025 17:10
@drupol drupol force-pushed the push-kvvztlstmqlv branch from b727b0f to 7b5604c Compare April 20, 2025 17:13
Aleksanaa
Aleksanaa reviewed Apr 21, 2025
View reviewed changes
@drupol drupol force-pushed the push-kvvztlstmqlv branch from 7b5604c to 3218a42 Compare April 21, 2025 05:03
@github-actions github-actions bot added the 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. label Apr 21, 2025
@drupol
Copy link
Contributor Author

drupol commented Apr 21, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 400164 --package nixpkgs-manual

x86_64-linux

✅ 1 package built:
  • nixpkgs-manual

@Aleksanaa Aleksanaa merged commit c4170d9 into NixOS:master Apr 21, 2025
24 of 27 checks passed
@drupol drupol deleted the push-kvvztlstmqlv branch April 21, 2025 06:09
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Apr 21, 2025

Backport failed for release-24.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.11
git worktree add -d .worktree/backport-400164-to-release-24.11 origin/release-24.11
cd .worktree/backport-400164-to-release-24.11
git switch --create backport-400164-to-release-24.11
git cherry-pick -x 540ddbcf2ff3d194d190bab59ecadf14b1532681 47f000d991220f689bbfb32406cdc4a24b83ac3c b4515ff6c24516b4a19262239a5002d9553ca750 30eb01e120bfa3180542bf6fade9b35c970913f8 ac04a5c492f7668882e99c0b5075aaa81a434713 3218a4204f02eb8a2f78ec5671207682cc694c2f

This was referenced Apr 21, 2025
Merged
Closed
@katexochen katexochen mentioned this pull request Apr 25, 2025
Merged
13 tasks
@nh2 nh2 mentioned this pull request May 24, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Aleksanaa Aleksanaa Aleksanaa approved these changes

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@fricklerhandwerk fricklerhandwerk Awaiting requested review from fricklerhandwerk

+1 more reviewer

@0xda157 0xda157 0xda157 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: agda A dependently typed programming language / interactive theorem prover 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 6.topic: java Including JDK, tooling, other languages, other VMs 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 6.topic: TeX Issues regarding texlive and TeX in general 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@drupol @Aleksanaa @0xda157