Skip to content

doc: Fix missing pre/post hooks everywhere#318737

Merged
nh2 merged 2 commits intoNixOS:masterfrom
nh2:doc-hook-phases
May 24, 2025
Merged

doc: Fix missing pre/post hooks everywhere#318737
nh2 merged 2 commits intoNixOS:masterfrom
nh2:doc-hook-phases

Conversation

@nh2
Copy link
Contributor

@nh2 nh2 commented Jun 10, 2024

Description of changes

Things done

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 8.has: documentation This PR adds or changes documentation 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 6.topic: agda A dependently typed programming language / interactive theorem prover labels Jun 10, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 10, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 4, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 2, 2025
@nh2 nh2 force-pushed the doc-hook-phases branch from f198d12 to ee6c2bd Compare May 24, 2025 13:23
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label May 24, 2025
@github-actions github-actions bot added 6.topic: java Including JDK, tooling, other languages, other VMs and removed 6.topic: agda A dependently typed programming language / interactive theorem prover labels May 24, 2025
@nh2
Copy link
Contributor Author

nh2 commented May 24, 2025

I rebased.

Some of the changes were already fixed by #400164

@nh2
Copy link
Contributor Author

nh2 commented May 24, 2025

nixpkgs-review report invoked like in #400164 (comment):

--------- Report for 'x86_64-linux' ---------
2 packages built:
nixpkgs-manual nixpkgs-manual.passthru.tests.check-nix-code-blocks

@nh2
Copy link
Contributor Author

nh2 commented May 24, 2025

Adding potential reviewers @Aleksanaa @drupol from #400164

FliegendeWurst
FliegendeWurst reviewed May 24, 2025
View reviewed changes
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 24, 2025
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label May 24, 2025
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label May 24, 2025
@nh2 nh2 merged commit 4684fd6 into NixOS:master May 24, 2025
2 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FliegendeWurst FliegendeWurst FliegendeWurst left review comments

@drupol drupol drupol approved these changes

@lilyinstarlight lilyinstarlight Awaiting requested review from lilyinstarlight

@winterqt winterqt Awaiting requested review from winterqt

@RaitoBezarius RaitoBezarius Awaiting requested review from RaitoBezarius

@chayleaf chayleaf Awaiting requested review from chayleaf

@Infinidoge Infinidoge Awaiting requested review from Infinidoge

@tomodachi94 tomodachi94 Awaiting requested review from tomodachi94

Assignees

No one assigned

Labels

6.topic: java Including JDK, tooling, other languages, other VMs 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nh2 @drupol @FliegendeWurst @wegank