Skip to content

doc: cleanup, use src.tag where it make sense, add missing phase hooks, use finalAttrs pattern#396846

Closed
drupol wants to merge 4 commits intoNixOS:masterfrom
drupol:push-wozmsymtqtso
Closed

doc: cleanup, use src.tag where it make sense, add missing phase hooks, use finalAttrs pattern#396846
drupol wants to merge 4 commits intoNixOS:masterfrom
drupol:push-wozmsymtqtso

Conversation

@drupol
Copy link
Contributor

@drupol drupol commented Apr 7, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: agda A dependently typed programming language / interactive theorem prover 6.topic: java Including JDK, tooling, other languages, other VMs 6.topic: nim Nim programing language 6.topic: php PHP is a general-purpose scripting language geared towards web development. 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 7, 2025
@drupol drupol marked this pull request as ready for review April 7, 2025 16:04
@drupol drupol force-pushed the push-wozmsymtqtso branch from 833023c to 3e2b6da Compare April 7, 2025 16:09
@drupol drupol requested a review from fricklerhandwerk April 7, 2025 16:10
GaetanLepage
GaetanLepage approved these changes Apr 7, 2025
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!!

@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS labels Apr 7, 2025
@drupol drupol changed the title doc: use src.tag where it make sense, add missing phase hooks doc: cleanup, use src.tag where it make sense, add missing phase hooks, use finalAttrs pattern Apr 7, 2025
@github-actions github-actions bot removed the 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. label Apr 7, 2025
@drupol drupol force-pushed the push-wozmsymtqtso branch from 43f516e to 229a513 Compare April 7, 2025 19:37
@drupol drupol marked this pull request as draft April 8, 2025 08:27
@drupol drupol force-pushed the push-wozmsymtqtso branch from 229a513 to 21a9af8 Compare April 8, 2025 09:41
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 17, 2025
@drupol
Copy link
Contributor Author

drupol commented Apr 21, 2025

Fixed in #400164

@drupol drupol closed this Apr 21, 2025
@drupol drupol deleted the push-wozmsymtqtso branch April 21, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GaetanLepage GaetanLepage GaetanLepage approved these changes

@fricklerhandwerk fricklerhandwerk Awaiting requested review from fricklerhandwerk

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: agda A dependently typed programming language / interactive theorem prover 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 6.topic: java Including JDK, tooling, other languages, other VMs 6.topic: nim Nim programing language 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 6.topic: php PHP is a general-purpose scripting language geared towards web development. 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 6.topic: TeX Issues regarding texlive and TeX in general 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@drupol @GaetanLepage @wegank