Skip to content

gajim: add hlad as maintainer#398914

Merged
7c6f434c merged 1 commit intoNixOS:masterfrom
hlad:gajim_hlad
Apr 15, 2025
Merged

gajim: add hlad as maintainer#398914
7c6f434c merged 1 commit intoNixOS:masterfrom
hlad:gajim_hlad

Conversation

@hlad
Copy link
Contributor

@hlad hlad commented Apr 15, 2025

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

@SigmaSquadron SigmaSquadron added the 3.skill: trivial This is trivial to complete (typically find-and-replace) label Apr 15, 2025
@github-actions github-actions bot added the 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. label Apr 15, 2025
@7c6f434c
Copy link
Member

@SigmaSquadron does this label even make sense for meta update PRs as opposed to issues?

@github-actions github-actions bot added the 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. label Apr 15, 2025
@7c6f434c 7c6f434c merged commit b0630a6 into NixOS:master Apr 15, 2025
23 checks passed
@SigmaSquadron
Copy link
Contributor

SigmaSquadron commented Apr 15, 2025

Well, good point. I've started adding the trivial label to PRs that require little to no review to let committers know at a glance what PRs won't take any time to review and merge. I'm not the only one to do this, so I assumed it was helpful. I will cease if it's an annoyance.

@7c6f434c
Copy link
Member

It is probably useful in general, but specifically for maintainer update with an existing maintainer it arguably requires some care during reviewing from anyone who is not an existing maintainer of the package, no?

@hlad hlad deleted the gajim_hlad branch April 15, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.skill: trivial This is trivial to complete (typically find-and-replace) 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants