Skip to content

libcosmicAppHook: replace stdenv.isDarwin with stdenv.hostPlatform.isDarwin#385120

Merged
GaetanLepage merged 1 commit intoNixOS:masterfrom
HeitorAugustoLN:libcosmic-apphook-hostplatform
Mar 3, 2025
Merged

libcosmicAppHook: replace stdenv.isDarwin with stdenv.hostPlatform.isDarwin#385120
GaetanLepage merged 1 commit intoNixOS:masterfrom
HeitorAugustoLN:libcosmic-apphook-hostplatform

Conversation

@HeitorAugustoLN
Copy link
Member

Related: #341407

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@HeitorAugustoLN HeitorAugustoLN force-pushed the libcosmic-apphook-hostplatform branch from 04c1d8f to 9090691 Compare February 25, 2025 23:36
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 25, 2025
@HeitorAugustoLN HeitorAugustoLN added 3.skill: trivial This is trivial to complete (typically find-and-replace) 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. labels Mar 3, 2025
@GaetanLepage GaetanLepage merged commit 37cb97a into NixOS:master Mar 3, 2025
29 checks passed
@HeitorAugustoLN HeitorAugustoLN deleted the libcosmic-apphook-hostplatform branch March 3, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.skill: trivial This is trivial to complete (typically find-and-replace) 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants