wireworld: fix Wireworld.desktop exec value to match binary#342340
Closed
rcmlz wants to merge 1 commit intoNixOS:masterfrom
Closed
wireworld: fix Wireworld.desktop exec value to match binary#342340rcmlz wants to merge 1 commit intoNixOS:masterfrom
rcmlz wants to merge 1 commit intoNixOS:masterfrom
Conversation
The desktopItem is not working, because the binary is "bin/Wireworld" (Capital W) but in the "share/applications/Wireworld.desktop" it is linked to "wireworld" (small W)
Member
|
Hey, I quit nixpkgs and thus won't be reviewing this #323901 |
FliegendeWurst
approved these changes
Nov 6, 2024
4 tasks
marcin-serwin
approved these changes
Jan 17, 2026
Contributor
marcin-serwin
left a comment
There was a problem hiding this comment.
This needs rebase but otherwise LGTM
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Wireworld.desktop is not working, because the binary is called "bin/Wireworld" (Capital W) but in the Wireworld.desktop the exec is linked to "wireworld" (small w)
Description of changes
Changed in Wireworld.desktop the parameter exec to "Wireworld" to match bin/Wireworld.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.