Skip to content

wireworld: fix Wireworld.desktop exec value to match binary#342340

Closed
rcmlz wants to merge 1 commit intoNixOS:masterfrom
rcmlz:wireworld
Closed

wireworld: fix Wireworld.desktop exec value to match binary#342340
rcmlz wants to merge 1 commit intoNixOS:masterfrom
rcmlz:wireworld

Conversation

@rcmlz
Copy link

@rcmlz rcmlz commented Sep 16, 2024

The Wireworld.desktop is not working, because the binary is called "bin/Wireworld" (Capital W) but in the Wireworld.desktop the exec is linked to "wireworld" (small w)

Description of changes

Changed in Wireworld.desktop the parameter exec to "Wireworld" to match bin/Wireworld.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

The desktopItem is not working, because the binary is "bin/Wireworld" (Capital W) but in the "share/applications/Wireworld.desktop" it is linked to "wireworld" (small W)
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Sep 16, 2024
@rcmlz rcmlz requested a review from Janik-Haag September 17, 2024 13:21
@Janik-Haag
Copy link
Member

Hey, I quit nixpkgs and thus won't be reviewing this #323901

@Janik-Haag Janik-Haag removed their request for review September 17, 2024 16:15
@FliegendeWurst FliegendeWurst added 3.skill: trivial This is trivial to complete (typically find-and-replace) 12.approvals: 1 This PR was reviewed and approved by one person. labels Nov 6, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 10, 2024
@nixpkgs-ci nixpkgs-ci bot added 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 12.first-time contribution This PR is the author's first one; please be gentle! labels Jun 25, 2025
@nixpkgs-ci nixpkgs-ci bot removed the 12.first-time contribution This PR is the author's first one; please be gentle! label Nov 2, 2025
Copy link
Contributor

@marcin-serwin marcin-serwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs rebase but otherwise LGTM

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 12.approvals: 1 This PR was reviewed and approved by one person. labels Jan 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 3.skill: trivial This is trivial to complete (typically find-and-replace) 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants