qt6.qtdeclarative: fix code-signing on Darwin#398849
qt6.qtdeclarative: fix code-signing on Darwin#398849thiagokokada merged 1 commit intoNixOS:masterfrom
Conversation
nix-owners
bot
requested review from
K900,
NickCao,
SuperSandro2000 and
ttuegel
github-actions
bot
added
10.rebuild-darwin: 101-500
There was a problem hiding this comment.
We should make this none linux conditional and eat the rebuilds in my opinion to notice when it no longer applies as I think all maintainers are not that deep into darwin.
Also nixfmt is unhappy.
There was a problem hiding this comment.
Fixed the formatting. @K900, are you fine with eating the rebuilds? I can drop the conditional if so.
There was a problem hiding this comment.
We can just merge this, then drop the conditional next cycle.
The build tries to sign qmltestrunner, but sometimes it’s already signed, causing the signing to fail due to an existing signature. Cherry-pick this patch from upstream to force sign it regardless.
reckenrode
force-pushed
the
push-romwyzlrzzsp
branch
from
21ab403 to
b403bd0
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
|
Any idea why this fix doesn't seem to work on 24.11? |
|
Hydra for 24.11 is failing because it can’t find |
6 participants
The build tries to sign qmltestrunner, but sometimes it’s already signed, causing the signing to fail due to an existing signature. Cherry-pick this patch from upstream to force sign it regardless.
I made this conditional on Darwin to target master without causing rebuilds on Linux.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.