[Backport release-24.11] qt6.qtdeclarative: fix code-signing on Darwin#401989
Merged
K900 merged 1 commit intoNixOS:release-24.11from Apr 26, 2025
Merged
[Backport release-24.11] qt6.qtdeclarative: fix code-signing on Darwin#401989K900 merged 1 commit intoNixOS:release-24.11from
K900 merged 1 commit intoNixOS:release-24.11from
Conversation
The build tries to sign qmltestrunner, but sometimes it’s already signed, causing the signing to fail due to an existing signature. Cherry-pick this patch from upstream to force sign it regardless. (cherry picked from commit b403bd0)
vcunat
added
6.topic: darwin
nix-owners
bot
requested review from
K900,
NickCao,
SuperSandro2000 and
ttuegel
github-actions
bot
added
10.rebuild-darwin: 101-500
Member
Author
|
Now I built it locally and I still got the code-signing error 😢 |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Contributor
|
The nix fmt job failed, and thus is now failing in every PR to release-24.11. Fixed in #402065. |
Member
Author
|
Oh, I'm sorry, I forgot. And I really hate that extending a list makes you reindent every element of it. That's pretty hurtful to version control, etc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build tries to sign qmltestrunner, but sometimes it’s already signed, causing the signing to fail due to an existing signature. Cherry-pick this patch from upstream to force sign it regardless.
(cherry picked from commit b403bd0 from #398849)
Blocking channel via wireshark: https://hydra.nixos.org/build/295474305
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.