Conversation
|
@sarahec sorry for ping, but do you know how to find a cargoHash sha256 for this package?? |
|
Looks like upstream's Cargo.lock is extremely old, and the fetcher is unable to parse it because it lacks the Are you sure you want to add a project that's been unmaintained for over 4 years to Nixpkgs? Are there really no replacements for this? |
Hm. That's actually a good point. Well, I would like to have it upstream in nixpkgs because I want toggle feature in sketchybar. |
|
I just tested in homebrew (which builds from source) and |
|
@aspauldingcode to answer you question, the process is:
|
Thanks. |
|
I'm leaning towards not merging this since it's not maintained. I'll probably fork it and maintain my own fork, then open a pr for that project instead. |
|
I'd be more than happy to merge a PR that fixes the lockfile! Also, I'd contend that a project doesn't always require commit activity in order to be considered maintained - since it still builds and works on all of my machines, I haven't had a reason to ship a new release in four years! 😅 |
|
Also, I'd content that a project doesn't always require commit activity
in order to be considered maintained - since it still builds and works
on all of my machines, I haven't had a reason to ship a new release in
four years! 😅
I noticed your messages on the recent issues of that repo. Perhaps closing this was too hasty of a decision.
|
|
I tested running @aspauldingcode I don't know what your time looks like these days, but if you have the time this could be a valuable learning project. |
|
@sarahec I ran out of storage space and taking several classes, waiting on my new laptop to arrive before I merge my fixes, but I made some changes to nightlight I'd like to share and I'm not abandoning this pr just yet 😄 thanks for heads up on cargo dependencies |
|
Looks like I need cargo from unstable. Otherwise I cannot use |
You could also back up to an earlier edition, just not all the way back to 2018. |
d987c1b to
ddac134
Compare
|
Ready for review. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5445 |
There was a problem hiding this comment.
Reviewed points
- package path fits guidelines
- package name fits guidelines
- package version fits guidelines
-
meta.descriptionis set and fits guidelines -
meta.licensefits upstream license -
meta.platformsis set -
meta.maintainersis set -
meta.mainProgramis set, if applicable. - build time only dependencies are declared in
nativeBuildInputs - source is fetched using the appropriate function
- the list of
phasesis not overridden
Comments
Can’t build nor test it since I’m on Linux.
cde4f6d to
ff07c20
Compare
|
Brilliant suggestions. |
6d7cd34 to
42bb423
Compare
nicolas-goudry
left a comment
There was a problem hiding this comment.
LGTM but as I said previously I cannot build nor test it since I’m on Linux.
Thanks for contributing!
Nightlight cargo hash added. suggested changes sri hash change, remove unnecessary wrapper
f3291a9 to
c53f219
Compare
|
Add nightlight macOS utility to Nixpkgs upstream.
This package allows you to toggle and modify macOS vanilla Night Shift feature.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.