Skip to content

exegol: relax argcomplete#421037

Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom
Moraxyc:fix-exegol
Jul 4, 2025
Merged

exegol: relax argcomplete#421037
Aleksanaa merged 1 commit intoNixOS:masterfrom
Moraxyc:fix-exegol

Conversation

@Moraxyc
Copy link
Member

@Moraxyc Moraxyc commented Jun 29, 2025

Resolve #421024

Although 5.0.1 has been released, it includes a new dependency supabase, but the related PR #398562 has not been merged yet. Therefore, let’s apply a simple fix to resolve the build failure for now.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 29, 2025
@nix-owners nix-owners bot requested a review from charB66 June 29, 2025 15:59
@Moraxyc
Copy link
Member Author

Moraxyc commented Jun 29, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 421037
Commit: c2c36f691231fbc655ba0d9a52cc1d863bbeda57


x86_64-linux

✅ 2 packages built:
  • exegol
  • exegol.dist

aarch64-linux

✅ 2 packages built:
  • exegol
  • exegol.dist

x86_64-darwin

✅ 2 packages built:
  • exegol
  • exegol.dist

aarch64-darwin

✅ 2 packages built:
  • exegol
  • exegol.dist

@Moraxyc Moraxyc mentioned this pull request Jun 29, 2025
3 tasks
Copy link
Contributor

@AkechiShiro AkechiShiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix

@AkechiShiro AkechiShiro added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 1, 2025
@Aleksanaa Aleksanaa merged commit 31804d7 into NixOS:master Jul 4, 2025
30 of 31 checks passed
@Moraxyc Moraxyc deleted the fix-exegol branch July 4, 2025 03:08
@AkechiShiro
Copy link
Contributor

AkechiShiro commented Aug 1, 2025

Hello @Moraxyc,

The needed dependency for version 5.X.X has been merged in unstable,

Feel free to let me know, if you might push a PR to update Exegol, if I find some time, I'll try to do it on my end.

@Moraxyc Moraxyc mentioned this pull request Aug 1, 2025
13 tasks
@Moraxyc
Copy link
Member Author

Moraxyc commented Aug 1, 2025

The needed dependency for version 5.X.X has been merged in unstable,

Thank you for letting me know! I've done the work in #430154.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure: exegol

3 participants