Merged
Conversation
github-actions
bot
added
10.rebuild-darwin: 5001+
Member
|
This seems to break cmake currently. We need to backport https://gitlab.kitware.com/cmake/cmake/-/commit/1b0c92a3a1b782ff3e1c4499b6ab8db614d45bcd |
Member
|
Please add this one as a patch; lix 2.92 and up experiences a serious regression without it: curl/curl@5fbd78e for details on our saga of pain see https://git.lix.systems/lix-project/lix/issues/662 |
https://github.com/curl/curl/releases/tag/curl-8_13_0 https://daniel.haxx.se/blog/2025/04/02/curl-8-13-0 https://curl.se/ch/8.13.0.html Signed-off-by: misilelab <misileminecord@gmail.com>
Signed-off-by: misilelab <misileminecord@gmail.com>
lf-
approved these changes
Apr 11, 2025
wegank
added
the
12.approvals: 1
lf-
approved these changes
Apr 26, 2025
Member
lf-
left a comment
lf-
left a comment
There was a problem hiding this comment.
Looked at this again since it stalled. I am not comfortable hitting the merge button myself since I am not a regular curl maintainer and am not super familiar with these types of large scale package changes. However, I think someone should hit the merge button once the curl nixpkgs maintainers look at it.
Scrumplex
approved these changes
Apr 27, 2025
Member
Scrumplex
left a comment
Scrumplex
left a comment
There was a problem hiding this comment.
All tests pass on x86_64-linux (Note that I rebased the two commits onto master)
13 tasks
lf-
pushed a commit
to lix-project/lix
that referenced
this pull request
Jun 13, 2025
We upgrade to 25.05 release, which contains the curl commit curl/curl@5fbd78e done in NixOS/nixpkgs#396200 (comment). This fixes HTTP transfers generating arbitrary errors and possibly failing unusually. Users who are already depending on 25.05-small or a recent unstable already had the fix. Special mention to the Linux kernel who gave me the opportunity to get on a 24 hours bisection side quest to fix the local release engineering test. Special thanks to everyone who had to endure me ranting. Change-Id: I866caf65d5ea103f1fa5eccd57df8031c9eacda0 Co-authored-by: eldritch horrors <pennae@lix.systems> Co-authored-by: helle <helle@h3l.li> Signed-off-by: Raito Bezarius <raito@lix.systems>
lf-
pushed a commit
to lix-project/lix
that referenced
this pull request
Jun 19, 2025
We upgrade to 25.05 release, which contains the curl commit curl/curl@5fbd78e done in NixOS/nixpkgs#396200 (comment). This fixes HTTP transfers generating arbitrary errors and possibly failing unusually. Users who are already depending on 25.05-small or a recent unstable already had the fix. Special mention to the Linux kernel who gave me the opportunity to get on a 24 hours bisection side quest to fix the local release engineering test. Special thanks to everyone who had to endure me ranting. Change-Id: I866caf65d5ea103f1fa5eccd57df8031c9eacda0 Co-authored-by: eldritch horrors <pennae@lix.systems> Co-authored-by: helle <helle@h3l.li> Signed-off-by: Raito Bezarius <raito@lix.systems> (cherry picked from commit 1e34c37)
13 tasks
dot-file
added a commit
to dot-file/nixpkgs
that referenced
this pull request
Aug 21, 2025
The curl issue that made 2.92 and up unstable has been solved: - https://git.lix.systems/lix-project/lix/issues/662#issuecomment-10236 - NixOS#396200 So there doesn't seem to be a reason not to make "stable" default to 2.93
lf-
pushed a commit
to lix-project/lix
that referenced
this pull request
Sep 10, 2025
We upgrade to 25.05 release, which contains the curl commit curl/curl@5fbd78e done in NixOS/nixpkgs#396200 (comment). This fixes HTTP transfers generating arbitrary errors and possibly failing unusually. Users who are already depending on 25.05-small or a recent unstable already had the fix. Special mention to the Linux kernel who gave me the opportunity to get on a 24 hours bisection side quest to fix the local release engineering test. Special thanks to everyone who had to endure me ranting. Change-Id: I866caf65d5ea103f1fa5eccd57df8031c9eacda0 Co-authored-by: eldritch horrors <pennae@lix.systems> Co-authored-by: helle <helle@h3l.li> Co-authored-by: Alois Wohlschlager <alois1@gmx-topmail.de> Signed-off-by: Raito Bezarius <raito@lix.systems>
lf-
pushed a commit
to lix-project/lix
that referenced
this pull request
Sep 10, 2025
We upgrade to 25.05 release, which contains the curl commit curl/curl@5fbd78e done in NixOS/nixpkgs#396200 (comment). This fixes HTTP transfers generating arbitrary errors and possibly failing unusually. Users who are already depending on 25.05-small or a recent unstable already had the fix. Special mention to the Linux kernel who gave me the opportunity to get on a 24 hours bisection side quest to fix the local release engineering test. Special thanks to everyone who had to endure me ranting. Change-Id: I866caf65d5ea103f1fa5eccd57df8031c9eacda0 Co-authored-by: eldritch horrors <pennae@lix.systems> Co-authored-by: helle <helle@h3l.li> Co-authored-by: Alois Wohlschlager <alois1@gmx-topmail.de> Signed-off-by: Raito Bezarius <raito@lix.systems>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://curl.se/ch/8.13.0.html
https://daniel.haxx.se/blog/2025/04/02/curl-8-13-0
https://github.com/curl/curl/releases/tag/curl-8_13_0
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.