Skip to content

Update lix stable: 2.91 -> 2.93#435185

Merged
lf- merged 1 commit intoNixOS:masterfrom
dot-file:lix-stable-2.91-to-2.93
Aug 22, 2025
Merged

Update lix stable: 2.91 -> 2.93#435185
lf- merged 1 commit intoNixOS:masterfrom
dot-file:lix-stable-2.91-to-2.93

Conversation

@dot-file
Copy link
Contributor

@dot-file dot-file commented Aug 20, 2025

pkgs.lix and pkgs.lixPackageSets.stable.lix point to lix_2_91 even though the latest version is lix_2_93.
In the derivation there's a comment that says:

  # Note: This is not yet 2.92 because of a non-deterministic `curl` error.
  # See: https://git.lix.systems/lix-project/lix/issues/662
  stable = self.lix_2_91;

However the curl issue that made 2.92 and up unstable has been solved:

So I made "stable" point to lix_2_93 instead.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle! labels Aug 20, 2025
Copy link
Member

@lf- lf- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the only things I'm aware of that are worse on 2.93 are cache query perf and we fixed that in 2.94 (upcoming). let's send it.

@lf-
Copy link
Member

lf- commented Aug 20, 2025

your commit message however is not compliant, please fix it before we can merge. "lixPackageSets.stable: 2.91 -> 2.93" or something like that.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Aug 20, 2025
The curl issue that made 2.92 and up unstable has been solved:
- https://git.lix.systems/lix-project/lix/issues/662#issuecomment-10236
- NixOS#396200

So there doesn't seem to be a reason not to make "stable" default to 2.93
@dot-file dot-file force-pushed the lix-stable-2.91-to-2.93 branch from 35d255c to 09a15ac Compare August 21, 2025 19:50
@dot-file
Copy link
Contributor Author

your commit message however is not compliant, please fix it before we can merge.

Done

@lf- lf- merged commit d8b0eea into NixOS:master Aug 22, 2025
24 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants