lixPackageSets.stable.lix: 2.91 -> 2.92#405718
Closed
ipetkov wants to merge 1 commit intoNixOS:masterfrom
Closed
Conversation
9999years
suggested changes
May 9, 2025
Contributor
Author
|
Ah thank you, I missed that it was targeting staging 😅 |
Contributor
|
v2.93.0 is already out, is there a point in this PR? |
Contributor
Author
|
Member
|
I'm still in favor of skipping 2.92 for now and just package 2.93 for the simplicity of maintenance. |
Contributor
Author
|
Alternatively I could have this MR re-target |
13 tasks
Contributor
Author
|
Based on the conversation in #398141 looks like there's a regression in 2.93 which prevents it from being considered stable. Until it is resolved I still think there is value in bumping stable to 2.92 |
Contributor
Author
|
Closing based on: #426260 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
lixPackageSets.stablebump to 2.92 was blocked on https://git.lix.systems/lix-project/lix/issues/662 which appears to be resolved with #396200cc @lf- in case this is incorrect!
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.