Skip to content

lixPackageSets.stable.lix: 2.91 -> 2.92#405718

Closed
ipetkov wants to merge 1 commit intoNixOS:masterfrom
ipetkov:lix-stable-2.92
Closed

lixPackageSets.stable.lix: 2.91 -> 2.92#405718
ipetkov wants to merge 1 commit intoNixOS:masterfrom
ipetkov:lix-stable-2.92

Conversation

@ipetkov
Copy link
Contributor

@ipetkov ipetkov commented May 9, 2025

The lixPackageSets.stable bump to 2.92 was blocked on https://git.lix.systems/lix-project/lix/issues/662 which appears to be resolved with #396200

cc @lf- in case this is incorrect!

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 9, 2025
@nix-owners nix-owners bot requested review from 9999years, Qyriad, RaitoBezarius and lf- May 9, 2025 22:12
Copy link
Contributor

@9999years 9999years left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#396200 is not quite in master yet, but soon!

https://nixpk.gs/pr-tracker.html?pr=396200

@ipetkov
Copy link
Contributor Author

ipetkov commented May 9, 2025

Ah thank you, I missed that it was targeting staging 😅

@acid-bong
Copy link
Contributor

v2.93.0 is already out, is there a point in this PR?

@ipetkov
Copy link
Contributor Author

ipetkov commented May 11, 2025

  1. This PR was opened before the new release was announced
  2. The 2.93 release has not been packaged yet, so there's still a point to landing this in the meantime.

@RaitoBezarius
Copy link
Member

I'm still in favor of skipping 2.92 for now and just package 2.93 for the simplicity of maintenance.

@ipetkov
Copy link
Contributor Author

ipetkov commented May 12, 2025

Alternatively I could have this MR re-target staging instead and let the changes rollout as they roll out in case there are other delays packaging 2.93. But I'll defer to the Lix maintainers here, just let me know whether to close this or keep waiting for #396200 to hit master!

@getchoo getchoo mentioned this pull request May 15, 2025
13 tasks
@ipetkov ipetkov force-pushed the lix-stable-2.92 branch from 3fbbfb6 to 34b0b05 Compare May 15, 2025 23:49
@ipetkov ipetkov requested a review from 9999years May 15, 2025 23:53
@ipetkov
Copy link
Contributor Author

ipetkov commented May 16, 2025

Based on the conversation in #398141 looks like there's a regression in 2.93 which prevents it from being considered stable. Until it is resolved I still think there is value in bumping stable to 2.92

@ipetkov
Copy link
Contributor Author

ipetkov commented Jul 31, 2025

Closing based on: #426260 (comment)

@ipetkov ipetkov closed this Jul 31, 2025
@ipetkov ipetkov deleted the lix-stable-2.92 branch July 31, 2025 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants