Remove references to older emacsen#389689
Closed
AndersonTorres wants to merge 6 commits intoNixOS:masterfrom
Closed
Remove references to older emacsen#389689AndersonTorres wants to merge 6 commits intoNixOS:masterfrom
AndersonTorres wants to merge 6 commits intoNixOS:masterfrom
Conversation
github-actions
bot
added
6.topic: emacs
13 tasks
jian-lin
reviewed
Mar 30, 2025
AndersonTorres
force-pushed
the
remove-old-emacs
branch
2 times, most recently
from
f2e156e to
b349dad
Compare
AndersonTorres
force-pushed
the
remove-old-emacs
branch
from
b349dad to
1f86437
Compare
Since version is guarranteed to be at least 30.
Because Emacs >= 30 has native JSON support and we no longer provide support for older Emacsen.
AndersonTorres
force-pushed
the
remove-old-emacs
branch
from
1f86437 to
28b350f
Compare
AndersonTorres
changed the title
nix-owners
bot
requested review from
adisbladis,
matthewbauer,
panchoh and
ttuegel
jian-lin
requested changes
Apr 24, 2025
Member
Author
|
Maybe this can be merged after #393512? |
This was referenced May 17, 2025
Member
Author
|
I think that this PR can be closed after #408550, since the commits not depending on Emacs > 28 passed. In the future anyone can grab this again. |
Contributor
|
Closing as requested |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.