emacs: rework imagemagick detection#408052
Merged
jian-lin merged 1 commit intoNixOS:masterfrom May 18, 2025
Merged
Conversation
We do not have Emacs 27 anymore. We set this as false by default because it is the previous behaviour for Emacs > 27. Further, the test `(withX || withNS)` is migrated to an assertion.
nix-owners
bot
requested review from
adisbladis,
matthewbauer,
panchoh and
ttuegel
github-actions
bot
added
10.rebuild-darwin: 0
jian-lin
approved these changes
May 17, 2025
wegank
added
the
12.approvals: 1
panchoh
approved these changes
May 17, 2025
wegank
added
12.approvals: 2
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We do not have Emacs 27 anymore.
We set this as false by default because it is the previous behaviour for Emacs >
27. Further, the test
(withX || withNS)is migrated to an assertion.Split from #389689
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.