emacs: remove native-comp-compiler-options-28.patch#408550
Merged
jian-lin merged 1 commit intoNixOS:masterfrom May 19, 2025
Merged
emacs: remove native-comp-compiler-options-28.patch#408550jian-lin merged 1 commit intoNixOS:masterfrom
jian-lin merged 1 commit intoNixOS:masterfrom
Conversation
nix-owners
bot
requested review from
adisbladis,
jian-lin,
matthewbauer,
panchoh and
ttuegel
jian-lin
approved these changes
May 18, 2025
Contributor
jian-lin
left a comment
jian-lin
left a comment
There was a problem hiding this comment.
LGTM, thanks!
nit: I would use only one commit for this.
github-actions
bot
added
10.rebuild-darwin: 0
Since we do not deal with older Emacsen. P.S.: We can't delete native-comp-compiler-options.patch yet, because Emacs Macport is stuck in Emacs 29.
AndersonTorres
force-pushed
the
emacs-set-version-test
branch
from
1621412 to
456ab11
Compare
Member
Author
Done, and reworded to explain the status quo of Macport. |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworked from #389689
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.