Skip to content

Comments

[24.05] electron_31: init at 31.4.0, electron: bump default version to v31, element-desktop: use electron_31#336018

Merged
emilazy merged 8 commits intoNixOS:release-24.05from
teutat3s:backport-electron-31
Aug 25, 2024
Merged

[24.05] electron_31: init at 31.4.0, electron: bump default version to v31, element-desktop: use electron_31#336018
emilazy merged 8 commits intoNixOS:release-24.05from
teutat3s:backport-electron-31

Conversation

@teutat3s
Copy link
Member

@teutat3s teutat3s commented Aug 20, 2024

Description of changes

Manual backport of #333907 and #330323.
Bumps the default electron version to 31, because 29 is EOL today #335850.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@teutat3s teutat3s requested a review from yayayayaka August 20, 2024 08:02
@teutat3s teutat3s changed the title [24.05] electron_31: init at 31.4.0, electron: bump default version to v31 [24.05] electron_31: init at 31.4.0, electron: bump default version to v31, element-desktop: use electron_31 Aug 20, 2024
teutat3s and others added 8 commits August 20, 2024 10:32
Co-authored-by: Yureka <yuka@yuka.dev>
(cherry picked from commit 2e7a16d)
Last contributions were in 2018 and 2015. Update list to de-facto
maintainers.

(cherry picked from commit d5ccd64)
Upstream switched to electron 31 in version 1.11.70
element-hq/element-desktop@597f356

(cherry picked from commit 376b7ca)
Co-authored-by: Yureka <yuka@yuka.dev>
(cherry picked from commit 080e1c1)
@teutat3s teutat3s force-pushed the backport-electron-31 branch from efe7ccf to 9863623 Compare August 20, 2024 08:33
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Aug 20, 2024
@teutat3s
Copy link
Member Author

Result of nixpkgs-review pr 336018 run on x86_64-linux 1

1 package marked as broken and skipped:
  • itch
52 packages built:
  • affine
  • antares
  • bilibili
  • bitwarden-directory-connector
  • breitbandmessung
  • bruno
  • camunda-modeler
  • chatd
  • drawio
  • drawio-headless
  • electron (electron_31)
  • electron-bin (electron_31-bin)
  • electron-chromedriver_31
  • element-desktop
  • element-desktop-wayland
  • fcast-receiver
  • freetube
  • geogebra6
  • headset
  • jitsi-meet-electron
  • koodo-reader
  • mattermost-desktop
  • nix-tour
  • open-stage-control
  • pandoc-drawio-filter
  • pandoc-drawio-filter.dist
  • podman-desktop
  • pritunl-client
  • protonmail-desktop
  • python311Packages.mkdocs-drawio-exporter
  • python311Packages.mkdocs-drawio-exporter.dist
  • python312Packages.mkdocs-drawio-exporter
  • python312Packages.mkdocs-drawio-exporter.dist
  • r2modman
  • redisinsight
  • revolt-desktop
  • sharedown
  • siyuan
  • standardnotes
  • stretchly
  • super-productivity
  • terra-station
  • tetrio-desktop
  • thedesk
  • threema-desktop
  • uhk-agent
  • uhk-udev-rules
  • uivonim
  • vesktop
  • vieb
  • youtube-music
  • ytdownloader

@emilazy
Copy link
Member

emilazy commented Aug 25, 2024

I think we can just merge this and monitor fallout? (unless anyone strongly objects)

@emilazy emilazy added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Aug 25, 2024
@emilazy emilazy merged commit be5f3e2 into NixOS:release-24.05 Aug 25, 2024
@teutat3s teutat3s deleted the backport-electron-31 branch August 26, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants