Skip to content

wastebin: 2.7.1 -> 3.0.0#387581

Closed
pinpox wants to merge 3 commits intoNixOS:masterfrom
pinpox:wastebin-update-3.0.0
Closed

wastebin: 2.7.1 -> 3.0.0#387581
pinpox wants to merge 3 commits intoNixOS:masterfrom
pinpox:wastebin-update-3.0.0

Conversation

@pinpox
Copy link
Member

@pinpox pinpox commented Mar 6, 2025

Targeting staging, as master has an outdated rustc version still. See #387198 for details.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 6, 2025
@nix-owners nix-owners bot requested a review from matthiasbeyer March 6, 2025 12:54
@pinpox pinpox changed the title WIP: wastebin: 2.7.1 -> 3.0.0 wastebin: 2.7.1 -> 3.0.0 Mar 6, 2025
Copy link
Member

@06kellyjac 06kellyjac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a release note noting a major version bump and linking to the docs on breaking changes 🙂

@wegank wegank added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. 12.approvals: 1 This PR was reviewed and approved by one person. labels Mar 9, 2025
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation labels Mar 13, 2025
@pinpox
Copy link
Member Author

pinpox commented Mar 13, 2025

@06kellyjac Added a note. Hope that is the correct place to add them.

@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 13, 2025
@github-actions github-actions bot removed the 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. label Mar 13, 2025
Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the staging merge commit and squash your changes into one commit.

@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 13, 2025
@pinpox pinpox changed the base branch from staging to master March 23, 2025 11:41
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 23, 2025
@pinpox pinpox mentioned this pull request Mar 23, 2025
13 tasks
@pinpox
Copy link
Member Author

pinpox commented Mar 23, 2025

Superseeded by #392357. The fixes have arrived in master, targeting staging is no longer necessary

@pinpox pinpox closed this Mar 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants