Skip to content

update flake to 2.7.0#93

Merged
matze merged 1 commit intomatze:masterfrom
pinpox:update-flake
Jan 18, 2025
Merged

update flake to 2.7.0#93
matze merged 1 commit intomatze:masterfrom
pinpox:update-flake

Conversation

@pinpox
Copy link
Contributor

@pinpox pinpox commented Jan 17, 2025

No description provided.

@pinpox pinpox mentioned this pull request Jan 17, 2025
@matze matze merged commit dfa1a35 into matze:master Jan 18, 2025
2 checks passed
@matze
Copy link
Owner

matze commented Jan 18, 2025

Thank you!

@matze
Copy link
Owner

matze commented Mar 5, 2025

@pinpox I just released 3.0.0, so if you could be so kind to open a PR for the corresponding flake update?

@pinpox
Copy link
Contributor Author

pinpox commented Mar 6, 2025

I'm looking into it, but I get this error now when updating:

error: failed to parse manifest at `/build/source/Cargo.toml`

Caused by:
  feature `edition2024` is required

  The package requires the Cargo feature called `edition2024`, but that feature is not stabilized in this version of Cargo (1.84.0 (66221abde 2024-11-19)).
  Consider adding `cargo-features = ["edition2024"]` to the top of Cargo.toml (above the [package] table) to tell Cargo you are opting in to use this unstable feature.
  See https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#edition-2024 for more information about the status of this feature.
error: builder for '/nix/store/7c8vd82hfhr0v6pkfq0zrqv08zf8l01w-wastebin-3.0.0.drv' failed with exit code 101;
       last 22 log lines:
       > Running phase: unpackPhase
       > unpacking source archive /nix/store/3l5y928hvgn4w3rnyvbri9872gyvn3k5-source
       > source root is source
       > Executing cargoSetupPostUnpackHook
       > Finished cargoSetupPostUnpackHook
       > Running phase: patchPhase
       > Executing cargoSetupPostPatchHook
       > Validating consistency between /build/source/Cargo.lock and /build/wastebin-3.0.0-vendor/Cargo.lock
       > Finished cargoSetupPostPatchHook
       > Running phase: updateAutotoolsGnuConfigScriptsPhase
       > Running phase: configurePhase
       > Running phase: buildPhase
       > Executing cargoBuildHook
       > cargoBuildHook flags: -j 8 --target x86_64-unknown-linux-gnu --offline --profile release
       > error: failed to parse manifest at `/build/source/Cargo.toml`
       >
       > Caused by:
       >   feature `edition2024` is required
       >
       >   The package requires the Cargo feature called `edition2024`, but that feature is not stabilized in this version of Cargo (1.84.0 (66221abde 2024-11-19)).
       >   Consider adding `cargo-features = ["edition2024"]` to the top of Cargo.toml (above the [package] table) to tell Cargo you are opting in to use this unstable feature.
       >   See https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#edition-2024 for more information about the status of this feature.

I'm not sure if this is nix-specific or a rust configuration issue. I'll try to find a solution, let me know if you anything about this, my rust is not that strong.

@matze
Copy link
Owner

matze commented Mar 6, 2025

wastebin 3.0.0 requires Rust 1.85 effectively. I know it's pretty recent but better to make such a hard requirement earlier than later.

@pinpox
Copy link
Contributor Author

pinpox commented Mar 6, 2025

Ok, seems 1.85 is already on its way to nixpkgs. I opened a draft PR for now (NixOS/nixpkgs#387581), will update when NixOS/nixpkgs#383902 has reached master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants