Skip to content

deno: 2.2.2 -> 2.2.3#387198

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
ofalvai:deno-2.2.3
Mar 12, 2025
Merged

deno: 2.2.2 -> 2.2.3#387198
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
ofalvai:deno-2.2.3

Conversation

@ofalvai
Copy link
Contributor

@ofalvai ofalvai commented Mar 5, 2025

Marking as draft until #383902 reaches master because deno_core requires the 2024 Rust edition:

deno> Caused by:
deno>   failed to parse manifest at `/private/tmp/nix-build-deno-2.2.3.drv-0/deno-2.2.3-vendor/deno_core-0.340.0/Cargo.toml`
deno> 
deno> Caused by:
deno>   feature `edition2024` is required
deno> 
deno>   The package requires the Cargo feature called `edition2024`, but that feature is not stabilized in this version of Cargo (1.84.0 (66221abde 2024-11-19)).
deno>   Consider trying a more recent nightly release.
deno>   See https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#edition-2024 for more information about the status of this feature.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofalvai ofalvai requested review from 06kellyjac and MisileLab March 5, 2025 07:04
MisileLab
MisileLab approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@MisileLab MisileLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think we can target staging instead of waiting.

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 5, 2025
@pinpox pinpox mentioned this pull request Mar 6, 2025
Closed
13 tasks
@ofalvai
Copy link
Contributor Author

ofalvai commented Mar 12, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 387198

aarch64-linux

❌ 10 packages failed to build:
  • deno
  • era
  • quarto
  • quartoMinimal
  • rstudio
  • rstudio-server
  • rstudioServerWrapper
  • rstudioWrapper
  • silverbullet
  • windmill

x86_64-darwin

✅ 9 packages built:
  • deno
  • era
  • quarto
  • quartoMinimal
  • rstudio
  • rstudio-server
  • rstudioServerWrapper
  • rstudioWrapper
  • silverbullet

aarch64-darwin

✅ 9 packages built:
  • deno
  • era
  • quarto
  • quartoMinimal
  • rstudio
  • rstudio-server
  • rstudioServerWrapper
  • rstudioWrapper
  • silverbullet

@ofalvai
Copy link
Contributor Author

ofalvai commented Mar 12, 2025

Now that Rust 1.85 landed on master, I did a few test builds and it always failed on aarch64-linux. I'm not sure why, the logs don't say too much:

Logs 
deno-aarch64-linux>    Compiling deno_doc v0.169.0
deno-aarch64-linux>
deno-aarch64-linux> thread 'main' panicked at cargo-auditable/src/rustc_wrapper.rs:109:39:
deno-aarch64-linux> called `Option::unwrap()` on a `None` value
deno-aarch64-linux> note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
deno-aarch64-linux> error: could not compile `deno` (bin "deno")
deno-aarch64-linux>
deno-aarch64-linux> Caused by:
deno-aarch64-linux>   process didn't exit successfully: `/nix/store/5sky2mmfb6syc36zzcl22fgiga9jr94b-cargo-auditable-0.6.5/bin/cargo-auditable rustc --crate-name deno --edition=2021 cli/main.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type bin --emit=dep-info,link -C opt-level=z -C lto -C codegen-units=1 --cfg 'feature="__vendored_zlib_ng"' --cfg 'feature="default"' --cfg 'feature="upgrade"' --check-cfg 'cfg(docsrs,test)' --check-cfg 'cfg(feature, values("__vendored_zlib_ng", "default", "dhat", "dhat-heap", "hmr", "lsp-tracing", "upgrade"))' -C metadata=57ca9bcbf1c6bf2a -C extra-filename=-dc71982a3aab61f1 --out-dir /build/source/target/aarch64-unknown-linux-gnu/release/deps --target aarch64-unknown-linux-gnu -C linker=/nix/store/ir7ny43iqgll895w0g7gqrl451apdny9-gcc-wrapper-14-20241116/bin/cc -C incremental=/build/source/target/aarch64-unknown-linux-gnu/release/incremental -L dependency=/build/source/target/aarch64-unknown-linux-gnu/release/deps -L dependency=/build/source/target/release/deps --extern anstream=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libanstream-096d66516e330d49.rlib --extern async_trait=/build/source/target/release/deps/libasync_trait-6691bb8bb1816cb2.so --extern base64=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libbase64-e8e5a5067b324325.rlib --extern bincode=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libbincode-9874b6b15cf12c5b.rlib --extern boxed_error=/build/source/target/release/deps/libboxed_error-a8d98dbda0f7c929.so --extern bytes=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libbytes-c3c1c25ba6752fd8.rlib --extern capacity_builder=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libcapacity_builder-fcda59ea57fa58ee.rlib --extern chrono=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libchrono-2d5d195b79dbcdb7.rlib --extern clap=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libclap-65cec51b0ba364d8.rlib --extern clap_complete=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libclap_complete-c0bacdc297e21bba.rlib --extern clap_complete_fig=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libclap_complete_fig-287c901879997e0c.rlib --extern color_print=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libcolor_print-d0fc9e0525f73e77.rlib --extern console_static_text=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libconsole_static_text-1c5286fee29e43b4.rlib --extern crossterm=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libcrossterm-79cfe398b36e5e85.rlib --extern dashmap=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libdashmap-f3edfcda66f415a5.rlib --extern deno_ast=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libdeno_ast-052cf2aeeb74220b.rlib --extern deno_cache_dir=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libdeno_cache_dir-5019e612aafcfd57.rlib --extern deno_config=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libdeno_config-6ea5fb5da9493a7a.rlib --extern deno_core=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libdeno_core-09b8cf3355cf6894.rlib --extern deno_doc=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libdeno_doc-c9bbbe38dc4e493d.rlib --extern deno_error=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libdeno_error-b942ac7d4d19bae9.rlib --extern deno_graph=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libdeno_graph-3c9603200b5edd20.rlib --extern deno_lib=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libdeno_lib-e73de970a6dbd171.rlib --extern deno_lint=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libdeno_lint-adecf3593f05aaed.rlib --extern deno_lockfile=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libdeno_lockfile-a636c71644b1f70d.rlib --extern deno_media_type=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libdeno_media_type-db95a5c8567b54a8.rlib --extern deno_npm=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libdeno_npm-e4c9b65772082edc.rlib --extern deno_npm_cache=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libdeno_npm_cache-f3449bb43454877e.rlib --extern deno_package_json=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libdeno_package_json-3c451616c0ec261d.rlib --extern deno_path_util=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libdeno_path_util-7c878d5bc01e1dce.rlib --extern deno_resolver=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libdeno_resolver-bb348bbbc004339e.rlib --extern deno_runtime=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libdeno_runtime-7de373b24e912fd1.rlib --extern deno_semver=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libdeno_semver-cb9b5191fd8a07a5.rlib --extern deno_snapshots=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libdeno_snapshots-6c5d6b3c7e88f629.rlib --extern deno_task_shell=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libdeno_task_shell-15f4fdb3a52cb2d3.rlib --extern deno_telemetry=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libdeno_telemetry-0d1d5e449d10829d.rlib --extern deno_terminal=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libdeno_terminal-21a8b2b1fbdb8827.rlib --extern tower_lsp=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libdeno_tower_lsp-c1c8613bc0e3dc74.rlib --extern dissimilar=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libdissimilar-817e0899d7e76649.rlib --extern dotenvy=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libdotenvy-eb55f43e284f05f0.rlib --extern dprint_plugin_json=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libdprint_plugin_json-fcd0c114ce063615.rlib --extern dprint_plugin_jupyter=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libdprint_plugin_jupyter-1c0c6d287283cdbb.rlib --extern dprint_plugin_markdown=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libdprint_plugin_markdown-219fd65b5bd37eb1.rlib --extern dprint_plugin_typescript=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libdprint_plugin_typescript-bdd60f2979e5eb33.rlib --extern fancy_regex=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libfancy_regex-b52c40299e8a02fa.rlib --extern faster_hex=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libfaster_hex-a1414c0dcab35893.rlib --extern flate2=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libflate2-47047b945ae5869b.rlib --extern fs3=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libfs3-60a77ec8cef89543.rlib --extern http=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libhttp-74e002728f99d50a.rlib --extern http_body=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libhttp_body-7e31e1f5570e9492.rlib --extern http_body_util=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libhttp_body_util-76d9a30132ecd1ce.rlib --extern import_map=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libimport_map-cafa468a392ebcbd.rlib --extern indexmap=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libindexmap-37495098c117c58f.rlib --extern jsonc_parser=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libjsonc_parser-07860ee0ce4c5d77.rlib --extern lazy_regex=/build/source/target/aarch64-unknown-linux-gnu/release/deps/liblazy_regex-dd9ff7a56ae02b80.rlib --extern libc=/build/source/target/aarch64-unknown-linux-gnu/release/deps/liblibc-ad12eda37dc6b2e3.rlib --extern libsui=/build/source/target/aarch64-unknown-linux-gnu/release/deps/liblibsui-ba0a74066bf65f93.rlib --extern libz_sys=/build/source/target/aarch64-unknown-linux-gnu/release/deps/liblibz_sys-93b64d7a4ba8d6ac.rlib --extern log=/build/source/target/aarch64-unknown-linux-gnu/release/deps/liblog-974d87230b9f44b6.rlib --extern lsp_types=/build/source/target/aarch64-unknown-linux-gnu/release/deps/liblsp_types-65ebd22b300a05e6.rlib --extern malva=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libmalva-6e9746f8a8b288e4.rlib --extern markup_fmt=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libmarkup_fmt-e1c6dd01234230c1.rlib --extern memmem=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libmemmem-100e40c9d609e9c2.rlib --extern nix=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libnix-da66d950b9aa54e7.rlib --extern node_resolver=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libnode_resolver-6e316f0ae8d72a01.rlib --extern notify=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libnotify-761300727b56f662.rlib --extern once_cell=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libonce_cell-18f7c5f29aa89f5d.rlib --extern open=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libopen-7b69a33a251444ec.rlib --extern opentelemetry=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libopentelemetry-6d1a3e68511c13a9.rlib --extern opentelemetry_otlp=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libopentelemetry_otlp-1062e0957d0b0632.rlib --extern opentelemetry_semantic_conventions=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libopentelemetry_semantic_conventions-99a308be5ca3f7de.rlib --extern opentelemetry_sdk=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libopentelemetry_sdk-08a5558de65d6d46.rlib --extern p256=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libp256-8b858c13182440bf.rlib --extern pathdiff=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libpathdiff-e02a20b8cfc9fe4b.rlib --extern percent_encoding=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libpercent_encoding-40514b0500b17fba.rlib --extern phf=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libphf-1c176bdec3c31c5b.rlib --extern pretty_yaml=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libpretty_yaml-9c1d1d7fd723a162.rlib --extern quick_junit=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libquick_junit-6842e691b953bb3c.rlib --extern rand=/build/source/target/aarch64-unknown-linux-gnu/release/deps/librand-f4000bc04c587369.rlib --extern regex=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libregex-8b081c15bd47b9fc.rlib --extern ring=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libring-f5556874dcc5a903.rlib --extern jupyter_runtime=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libruntimelib-6e0ef3bc58cba2db.rlib --extern rustc_hash=/build/source/target/aarch64-unknown-linux-gnu/release/deps/librustc_hash-a11c0020f69fc0c1.rlib --extern rustyline=/build/source/target/aarch64-unknown-linux-gnu/release/deps/librustyline-d76606c375259f9d.rlib --extern rustyline_derive=/build/source/target/release/deps/librustyline_derive-5ec7f2605250aa80.so --extern serde=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libserde-1b96693d3abeab8b.rlib --extern serde_repr=/build/source/target/release/deps/libserde_repr-916750af1467e882.so --extern sha2=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libsha2-e11d15025958d75a.rlib --extern shell_escape=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libshell_escape-3697c5e5f928887f.rlib --extern spki=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libspki-f1de5c4da3c4cd33.rlib --extern sqlformat=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libsqlformat-9a0f6871a4aced6c.rlib --extern strsim=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libstrsim-2cf7c5a2894395b2.rlib --extern sys_traits=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libsys_traits-e4e19818ccc3afeb.rlib --extern tar=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libtar-281947d872c87c7c.rlib --extern tempfile=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libtempfile-26dbeaf3b8331bb6.rlib --extern text_size=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libtext_size-4d8d6a7bda5107d3.rlib --extern text_lines=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libtext_lines-c73490c3b9ae70e2.rlib --extern thiserror=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libthiserror-b909bc564a36cd53.rlib --extern tokio=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libtokio-0db09032df1d36b3.rlib --extern tokio_util=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libtokio_util-15b35e2c3f446c40.rlib --extern tower=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libtower-90127d3389dc2d99.rlib --extern typed_arena=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libtyped_arena-5cc112a1f7968205.rlib --extern unicode_width=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libunicode_width-96f2ecc972841fea.rlib --extern uuid=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libuuid-ef63bb761f5600f6.rlib --extern walkdir=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libwalkdir-3f3086227ae63a2f.rlib --extern zip=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libzip-0f1a4c37d142cd72.rlib --extern zstd=/build/source/target/aarch64-unknown-linux-gnu/release/deps/libzstd-c80012603531cf32.rlib -C target-feature=-crt-static -D 'clippy::all' -D 'clippy::await_holding_refcell_ref' -D 'clippy::missing_safety_doc' -D 'clippy::undocumented_unsafe_blocks' --cfg tokio_unstable -C link-arg=-Wl,--export-dynamic-symbol-list=/build/source/ext/napi/generated_symbol_exports_list_linux.def -L native=/build/source/target/aarch64-unknown-linux-gnu/release/build/psm-ae4c231cc63defa3/out -L /build/source/target/aarch64-unknown-linux-gnu/release/gn_out/obj -L native=/build/source/target/aarch64-unknown-linux-gnu/release/build/ring-65b5843745ad83c0/out -L native=/build/source/target/aarch64-unknown-linux-gnu/release/build/libz-sys-22e71e4715abf167/out/lib -L native=/build/source/target/aarch64-unknown-linux-gnu/release/build/libz-sys-22e71e4715abf167/out/lib64 -L native=/build/source/target/aarch64-unknown-linux-gnu/release/build/libsqlite3-sys-768b5895be58672f/out -L native=/build/source/target/aarch64-unknown-linux-gnu/release/build/lcms2-sys-7bc903b62e0b74ae/out -L native=/build/source/target/aarch64-unknown-linux-gnu/release/build/zstd-sys-a88f3173417bb7b0/out` (exit status: 101)

@ofalvai
Copy link
Contributor Author

ofalvai commented Mar 12, 2025

Nevermind, it was an OOM issue.

@ofalvai
Copy link
Contributor Author

ofalvai commented Mar 12, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 387198

aarch64-linux

✅ 10 packages built:
  • deno
  • era
  • quarto
  • quartoMinimal
  • rstudio
  • rstudio-server
  • rstudioServerWrapper
  • rstudioWrapper
  • silverbullet
  • windmill

x86_64-darwin

✅ 9 packages built:
  • deno
  • era
  • quarto
  • quartoMinimal
  • rstudio
  • rstudio-server
  • rstudioServerWrapper
  • rstudioWrapper
  • silverbullet

aarch64-darwin

✅ 9 packages built:
  • deno
  • era
  • quarto
  • quartoMinimal
  • rstudio
  • rstudio-server
  • rstudioServerWrapper
  • rstudioWrapper
  • silverbullet

@ofalvai ofalvai marked this pull request as ready for review March 12, 2025 09:30
@github-actions github-actions bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. and removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 12, 2025
@SuperSandro2000 SuperSandro2000 merged commit 39c22ea into NixOS:master Mar 12, 2025
39 checks passed
@ofalvai ofalvai mentioned this pull request Mar 12, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@06kellyjac 06kellyjac 06kellyjac approved these changes

@GaetanLepage GaetanLepage GaetanLepage approved these changes

+2 more reviewers

@mnakama mnakama mnakama approved these changes

@MisileLab MisileLab MisileLab approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ofalvai @mnakama @SuperSandro2000 @06kellyjac @GaetanLepage @MisileLab