build-support/php: refactor build scripts#386757
Merged
drupol merged 14 commits intoNixOS:masterfrom Mar 5, 2025
Merged
Conversation
github-actions
bot
added
the
6.topic: php
ofborg
bot
added
the
2.status: merge conflict
drupol
force-pushed
the
push-wwwyxnkuytvr
branch
from
8da10ba to
0618c1f
Compare
ofborg
bot
removed
the
2.status: merge conflict
Contributor
Author
|
@ShamrockLee Do you mind having a look and let me know any improvements/simplification? |
github-actions
bot
added
10.rebuild-darwin: 11-100
drupol
force-pushed
the
push-wwwyxnkuytvr
branch
4 times, most recently
from
29e2be3 to
6b84d63
Compare
ShamrockLee
reviewed
Mar 3, 2025
drupol
force-pushed
the
push-wwwyxnkuytvr
branch
2 times, most recently
from
faee832 to
fb94364
Compare
nix-owners
bot
requested review from
Ma27,
aanderse,
globin,
piotrkwiecinski and
talyz
drupol
force-pushed
the
push-wwwyxnkuytvr
branch
2 times, most recently
from
3284204 to
21be32c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
drupol
force-pushed
the
push-wwwyxnkuytvr
branch
from
f04a7e8 to
bf7ed8f
Compare
Contributor
Author
|
I'm 90% sure that the hash change comes from an old PR. I'm quite confident that the current builder is quite stable, I would not worry about this at the moment. |
Contributor
Author
|
I could have used |
Contributor
|
I reckon it's fine to just remove invalid symlinks. Probably they should be resolved upstream. I don't think we should remove the check completely. |
This comment was marked as outdated.
This comment was marked as outdated.
drupol
force-pushed
the
push-wwwyxnkuytvr
branch
2 times, most recently
from
c3da137 to
968c83f
Compare
Contributor
There was a problem hiding this comment.
Wouldn't it be better to enable it by default?
Contributor
Author
There was a problem hiding this comment.
Actually, broken symlinks are something that might be something we can have since we use composer with --no-dev by default. This is why I disable it by default.
drupol
force-pushed
the
push-wwwyxnkuytvr
branch
from
968c83f to
be4c843
Compare
…t to `true` by default
drupol
force-pushed
the
push-wwwyxnkuytvr
branch
from
be4c843 to
c0999f4
Compare
Contributor
|
Contributor
Author
|
Good for you @piotrkwiecinski ? |
piotrkwiecinski
approved these changes
Mar 5, 2025
This was referenced Mar 15, 2025
13 tasks
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.11
git worktree add -d .worktree/backport-386757-to-release-24.11 origin/release-24.11
cd .worktree/backport-386757-to-release-24.11
git switch --create backport-386757-to-release-24.11
git cherry-pick -x 5387f9cc48c937a238ef9e6e7cebf9ccac14672d 25e851d0887cb5ca31b77ab038ac6490de1b4875 2e4faebd4d9e4dee920a2c884e0d37cd44a5625e 47f6b52a456670c292d42971f42f430137b6307a 874a6d7d366380bee5c87bf98b90ff6fad7a718c 7e70611b1ed00f61e2ea8da5a6f871ec2a06f6ea e7304f587a2d632839cb7481a9965f7309bc08d9 66d96a76b590edf9fd4f749ad9ad644f762a748e 6e8e6c413d7a189f85d3319b9e0ade14296eda53 1de8208e4a542d10b5fdfd52c35f6f2221f2df24 489ac4817f5ed4101d9865a551622ce80ec87a7f 64b246657df86cde5a8ff8f713fbd3721cb6b598 c0999f435e35bbee0968af460bc4db84bf9f6b11 1afb093ed66dcdd354ed1518ccbf46d4ea79503d |
Contributor
Author
|
Backport @ #391063 |
drupol
added a commit
that referenced
this pull request
Mar 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #385830
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.