Skip to content

buildNpmPackage: support finalAttrs through lib.extendMkDerivation#390099

Merged
drupol merged 3 commits intoNixOS:masterfrom
JohnRTitor:buildNpmPackage-finalAttrsv2
Mar 15, 2025
Merged

buildNpmPackage: support finalAttrs through lib.extendMkDerivation#390099
drupol merged 3 commits intoNixOS:masterfrom
JohnRTitor:buildNpmPackage-finalAttrsv2

Conversation

@JohnRTitor
Copy link
Member

Inspired from #382550.

Nixfmt is done on the 2nd commit to allow easier commit by commit review.

@github-actions github-actions bot added the 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment label Mar 15, 2025
@nix-owners nix-owners bot requested a review from winterqt March 15, 2025 10:47
@JohnRTitor JohnRTitor requested a review from philiptaron March 15, 2025 10:51
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Mar 15, 2025
@drupol
Copy link
Contributor

drupol commented Mar 15, 2025

You might be interested in this pattern: #386757 (comment)

@ShamrockLee
Copy link
Contributor

ShamrockLee commented Mar 15, 2025

You might be interested in this pattern: #386757 (comment)

I prefer doing one thing at one time, unless the tasks are tightly coupled with each other. The overriding improvement using finalAttrs can be proceed in a subsequent PR.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/git-blame-ignore-revs-and-build-helper-format-changes/61726/1

Copy link
Contributor

@philiptaron philiptaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it.

Copy link
Contributor

@ShamrockLee ShamrockLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@drupol drupol merged commit 3431290 into NixOS:master Mar 15, 2025
27 checks passed
@drupol
Copy link
Contributor

drupol commented Mar 15, 2025

W000000t!

@JohnRTitor JohnRTitor deleted the buildNpmPackage-finalAttrsv2 branch March 16, 2025 02:42
@JohnRTitor JohnRTitor mentioned this pull request Mar 16, 2025
13 tasks
@philiptaron
Copy link
Contributor

@JohnRTitor: could I requisition you to create the necessary backports to 24.11?

@JohnRTitor
Copy link
Member Author

Ah, my dear sir, your request is received with the utmost regard, and I shall attend to the matter with diligence. Pray rest assured that by tomorrow evening, the necessary backports shall be prepared to your satisfaction.

@drupol
Copy link
Contributor

drupol commented Mar 18, 2025

Stop it guys, you crack me up every time I read these kind of comments.

@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Mar 18, 2025

Backport failed for release-24.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.11
git worktree add -d .worktree/backport-390099-to-release-24.11 origin/release-24.11
cd .worktree/backport-390099-to-release-24.11
git switch --create backport-390099-to-release-24.11
git cherry-pick -x 70ae16e6bff005ab5ab40090a0dae4b92fad6a57 e6ca2b65cae19e23191213efc04b6341d61947f6 43bf9e325cd1599d88740e4f52f476cf7afad366

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants