mir,mir_2_15: Fix builds, modernise & fix VM tests#374873
mir,mir_2_15: Fix builds, modernise & fix VM tests#374873OPNA2608 merged 7 commits intoNixOS:masterfrom
Conversation
7a8d381 to
f4f726d
Compare
|
|
@lucasew |
|
5700556 to
b303af9
Compare
b303af9 to
15e3e66
Compare
Then I would've expected your
|
It seems to work again.
…Enabling Failure seems to have been noticed by upstream, I assume they'll look into it: canonical/mir#3716 (comment)
15e3e66 to
65d97c7
Compare
glog pkg-config file disappeared after NixOS#364543. - mir doesn't depend on it anymore - mir_2_15 did, and re-enabling the pkg-config file for the new glog version errored out Upstream decided to just drop glog as a dependency, so follow suit.
65d97c7 to
3c0a99e
Compare
|

1st:
mirandmir_2_15currently fail on master, for different reasons.mir: Borked testmir_2_15: Borked test + glog dropped pkg-config generation + new glog version errors out when used: glog: disable broken test #371915 (comment)Fix these builds, to unblock Mir-based compositors (Miriway & miracle-wm) and the Lomiri DE.
2nd:
Additionally, Alacritty, when launched in the VM tests, complains about the YAML config format:
A
lib.generators.toTOMLwas rejected in the past, so switch topkgs.formats.yaml. For consistency, switch the INI file generation topkgs.formats.inias well.3rd:
OfBorg fails to run the VM tests. Try some things to hopefully resolve this.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.