Skip to content

mir: 2.19.2 -> 2.19.3#374857

Merged
OPNA2608 merged 1 commit intoNixOS:masterfrom
OPNA2608:update/mir
Jan 19, 2025
Merged

mir: 2.19.2 -> 2.19.3#374857
OPNA2608 merged 1 commit intoNixOS:masterfrom
OPNA2608:update/mir

Conversation

@OPNA2608
Copy link
Contributor

https://github.com/canonical/mir/releases/tag/v2.19.3

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 18, 2025
Copy link
Member

@NickCao NickCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the aarch64-linux test might just by flaky?

@OPNA2608
Copy link
Contributor Author

OPNA2608 commented Jan 19, 2025

aarch64-linux VM tests work on my local aarch64-linux machine, failure also exists when OfBorg builds current version of mir. Seems to be an issue with the new OfBorg setup, hoping to address this over in #374873.

@OPNA2608 OPNA2608 added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 19, 2025
@OPNA2608 OPNA2608 merged commit 7019c02 into NixOS:master Jan 19, 2025
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants