workflows: switch to NIXPKGS_CI specific variables#373935
Conversation
As per NixOS/org#54, new variables are now NIXPKGS_CI_APP_ID and NIXPKGS_CI_APP_PRIVATE_KEY.
|
Humm, seems like secrets are not being passed properly? https://github.com/NixOS/nixpkgs/actions/runs/12781938173/job/35630648144 |
Apparently since we are callling a reusable workflow here, we need to explicitly pass the secrets. :(
|
Nice, looks like this works now! https://github.com/NixOS/nixpkgs/actions/runs/12782225893/job/35631361946 |
wolfgangwalther
left a comment
There was a problem hiding this comment.
LGTM.
Should we use the new token for the codeowners workflow, too? (Not sure whether it has the right permissions)
|
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.11
git worktree add -d .worktree/backport-373935-to-release-24.11 origin/release-24.11
cd .worktree/backport-373935-to-release-24.11
git switch --create backport-373935-to-release-24.11
git cherry-pick -x f6976283058deb6d6eaa30967c09b4ee471e3193 6ab6314d06d25d77c3052fb00c4bdf3d7a5027a2 38ebbf7c4fc018170ac80582f83eb076694ab010 |
|
Because I was confused for a sec: This PR doesn't need to be backported because:
|
|
Correct - I tried backporting to minimize conflicts, but then concluded the same. |
|
As this is not backported, this action now fails with (some?) backport PRs after they're merged:
I'm not really sure why this step runs? |
I had the same errors on every backport PR I did. After doing the backport of this in #378508, those seem to be gone now. |
Without a target run, we won't get any rebuild labels, rebuild counts or maintainer pings. This might have been correct before NixOS#373935, but by now we run eval on all commits on the target branch, so we should treat it as a failure if we can't find the run.
This will allow GitHub to run actions on those commits, specifically Eval action. Currently as these merges are commited by
github-actions, Eval doesn't run on the commits.ie, https://github.com/NixOS/nixpkgs/actions/runs/12646467735/job/35237397411?pr=371701 Processing failed due to fa2d66f commit was done by github-actions.
With this every periodic merge will be authored and commited by the nixpkgs-ci bot.
Supercedes #372041
Relevant org discussion: NixOS/org#54
PR created from a NixOS/nixpkgs branch as to make it easier to test.