[24.11]: Backport scheduled workflows#378508
Merged
wolfgangwalther merged 13 commits intoNixOS:release-24.11from Feb 1, 2025
Merged
[24.11]: Backport scheduled workflows#378508wolfgangwalther merged 13 commits intoNixOS:release-24.11from
wolfgangwalther merged 13 commits intoNixOS:release-24.11from
Conversation
(cherry picked from commit f5e3261)
Since haskell-updates is based on master, but merges into staging, we need to base it on a merge-base of staging and master. See NixOS#361143. I'm a bit worried that the information GitHub uses for displaying Pull-Requests becomes stale and this will “add” commits to the PR compared to the base anyways. We'll find out, I suppose. (cherry picked from commit f9f5325)
Lock the Ubuntu runner to ubuntu-22.04 to avoid accidental updates [1] and increase reproducibility. [1]: actions/runner-images#10636 (cherry picked from commit 2660dd1)
Link: actions/runner-images#10636 (cherry picked from commit fcfbe6f)
Same top-level ordering of keys / empty lines and same indentation for yaml lists. One blank line between each step. Makes it easier to read and compare the workflows. (cherry picked from commit 88afad8)
Less repetition, more consistency. (cherry picked from commit 51b8ad2)
(cherry picked from commit ba09688)
Apparently the skipping needs to happen on the calling workflow, otherwise those workflows show up as "failed" in forks instead of skipped. (cherry picked from commit d725592)
(cherry picked from commit 6ab6314)
Apparently since we are callling a reusable workflow here, we need to explicitly pass the secrets. :( (cherry picked from commit 38ebbf7)
As per NixOS/org#54, new variables are now NIXPKGS_CI_APP_ID and NIXPKGS_CI_APP_PRIVATE_KEY. (cherry picked from commit f697628)
(cherry picked from commit 668d72c)
From the nixpkgs-unstable channel: https://hydra.nixos.org/eval/1811194#tabs-inputs (cherry picked from commit d51aeeb)
github-actions
bot
added
6.topic: policy discussion
nix-owners
bot
requested review from
LeSuisse,
Mic92,
infinisil,
mweinelt,
philiptaron,
risicle and
zowoq
13 tasks
github-actions
bot
added
10.rebuild-darwin: 0
Contributor
Author
|
Check-cherry-picks fails because some of the commits were partly backported already, so many lines missing from the new diff for those. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Functionally, this is not required to be backported. But:
ci/#374921Things done
git diff master -- .github/workflows cion this branch only returns diff for the OWNERS file now, nothing else anymore.Add a 👍 reaction to pull requests you find important.