Skip to content

workflows/eval: fail hard without target run#378909

Merged
infinisil merged 2 commits intoNixOS:masterfrom
wolfgangwalther:ci-fail-eval-comparison
Feb 4, 2025
Merged

workflows/eval: fail hard without target run#378909
infinisil merged 2 commits intoNixOS:masterfrom
wolfgangwalther:ci-fail-eval-comparison

Conversation

@wolfgangwalther
Copy link
Contributor

Without a target run, we won't get any rebuild labels, rebuild counts or
maintainer pings. This might have been correct before #373935, but by
now we run eval on all commits on the target branch, so we should treat
it as a failure if we can't find the run.

As mentioned in #355847 (comment).

Resolves #378595

Things done


Add a 👍 reaction to pull requests you find important.

Without a target run, we won't get any rebuild labels, rebuild counts or
maintainer pings. This might have been correct before NixOS#373935, but by
now we run eval on all commits on the target branch, so we should treat
it as a failure if we can't find the run.
To be in line with the terminology introduced in the README.md in the
same folder.
@github-actions github-actions bot added 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: policy discussion Discuss policies to work in and around Nixpkgs backport release-24.11 labels Feb 2, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 2, 2025
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have this, especially also because there's a bunch of these failures recently, which are very opaque to the PRs not getting processed due to it

@infinisil infinisil merged commit 353c0a7 into NixOS:master Feb 4, 2025
25 of 27 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Feb 4, 2025

Successfully created backport PR for release-24.11:

@wolfgangwalther
Copy link
Contributor Author

especially also because there's a bunch of these failures recently, which are very opaque to the PRs not getting processed due to it

They seem to indicate a problem with GHA being overloaded, imho. They roughly appeared at the same time * when we enabled running eval on all commits on master / staging. This is probably pure coincidence and not related, but I still wonder whether anyone knows more about the source of those failures and whether we can do anything about them?

There were times when those happened on almost every push...

* to be fair, that was also the time when GitHub Actions announced the new public beta of their arm linux runners. So maybe stuff for GHA actions changed on a bigger scale and this is entirely unrelated to us.

@wolfgangwalther wolfgangwalther deleted the ci-fail-eval-comparison branch February 4, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: policy discussion Discuss policies to work in and around Nixpkgs 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI does not request review on some prs

3 participants