treewide: directly pass cargoRoot to fetcher#373541
Merged
K900 merged 15 commits intoNixOS:masterfrom Jun 3, 2025
Merged
Conversation
Contributor
Author
|
bdfc4cd to
8fc366b
Compare
ad51137 to
8b17bf6
Compare
Contributor
|
ack |
8b17bf6 to
52c345d
Compare
52c345d to
7ae9882
Compare
13 tasks
0cd264e to
3c65d8a
Compare
18c4a6b to
62a136b
Compare
62a136b to
8e87675
Compare
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #350541
You can run the following to test that it actually still can re-generate the FODs.
(I have left out
ceph's inner derivations from this command because they are not exposed directly)Note: I have split this PR into separate commits in case some parts need backporting.
Question: should the docs follow the formatting rules, or can it stay in a format that's more readable (single-line)?
Edit: was answered in comments
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.