Skip to content

[Backport release-25.05] doc/rust: pass cargoRoot to fetcher in example#413547

Merged
Aleksanaa merged 1 commit intoNixOS:release-25.05from
TomaSajt:cargo-root-docs-backport
Jun 6, 2025
Merged

[Backport release-25.05] doc/rust: pass cargoRoot to fetcher in example#413547
Aleksanaa merged 1 commit intoNixOS:release-25.05from
TomaSajt:cargo-root-docs-backport

Conversation

@TomaSajt
Copy link
Contributor

@TomaSajt TomaSajt commented Jun 3, 2025

(cherry picked from commit 8e87675)

Partial backport of #373541

This changes the recommeneded way of using cargoRoot inside the fetcher in the docs.

I probably wont be backporting the other parts of the PR.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@TomaSajt TomaSajt requested a review from K900 June 3, 2025 10:27
@github-actions github-actions bot added 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 4.workflow: backport This targets a stable branch 8.has: documentation This PR adds or changes documentation labels Jun 3, 2025
@nix-owners nix-owners bot requested review from figsoda, winterqt and zowoq June 3, 2025 10:28
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 3, 2025
@Aleksanaa Aleksanaa merged commit c8a0a68 into NixOS:release-25.05 Jun 6, 2025
17 of 18 checks passed
@TomaSajt TomaSajt deleted the cargo-root-docs-backport branch January 20, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.workflow: backport This targets a stable branch 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants