Skip to content

surrealist 3.0.8 -> 3.1.9#373428

Merged
pbsds merged 1 commit intoNixOS:masterfrom
MDM23:update-surrealist
Jan 15, 2025
Merged

surrealist 3.0.8 -> 3.1.9#373428
pbsds merged 1 commit intoNixOS:masterfrom
MDM23:update-surrealist

Conversation

@MDM23
Copy link
Contributor

@MDM23 MDM23 commented Jan 13, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 13, 2025
@pbsds pbsds added the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label Jan 15, 2025
@pbsbot
Copy link

pbsbot commented Jan 15, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 373428


x86_64-linux

✅ 1 package built:
  • surrealist

@pbsds pbsds merged commit 6797bf5 into NixOS:master Jan 15, 2025
46 checks passed
@pbsds
Copy link
Member

pbsds commented Jan 15, 2025

Hi, is it possible to create a nixos test for surrealdb? That would greatly increase confidence when testing bumps :)

@MDM23
Copy link
Contributor Author

MDM23 commented Jan 15, 2025

@pbsds You mean like automatically testing some basic functionality of the compiled binary together with surrealdb? I'm not sure if it is possibly, as surrealist currently does not provide any command line interface. What do you got in mind?

@pbsds
Copy link
Member

pbsds commented Jan 15, 2025

I was mainly thinking of testing the nixos module, checking that it is able to set up a new DB and do some basic operations on it. But if there are no cli interfaces nor any language bindings in nixpkgs than that is a blocker

@MDM23
Copy link
Contributor Author

MDM23 commented Jan 15, 2025

For surrealdb alone, it should be doable. So a test of its nixos module would be a great addition! We can issue queries from the CLI.

surrealist however is just a GUI client, so I don't see any possibility for an integration test there.

@pbsds
Copy link
Member

pbsds commented Jan 15, 2025

ah, my misunderstanding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants