Skip to content

edencommon: skip flaky test on darwin #369477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emilazy merged 1 commit into from
Jan 8, 2025
Merged

edencommon: skip flaky test on darwin #369477

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions pkgs/by-name/ed/edencommon/package.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,24 @@ stdenv.mkDerivation (finalAttrs: {

doCheck = true;

checkPhase = ''
runHook preCheck

# Skip flaky test on darwin
ctest -j $NIX_BUILD_CORES --output-on-failure ${
lib.optionalString stdenv.hostPlatform.isDarwin (
lib.escapeShellArgs [
"--exclude-regex"
(lib.concatMapStringsSep "|" (test: "^${lib.escapeRegex test}$") [
"ProcessInfoCache.addFromMultipleThreads"
])
]
)
}

runHook postCheck
'';

postPatch = ''
# The CMake build requires the FBThrift Python support even though
# it’s not used, presumably because of the relevant code having
Expand Down