qsv: 0.131.1 -> 0.138.0, build simplification

[itepastra]

Update qsv to version 0.138.0, also fix build

ZHF: #352882

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[uncenter]

I'm getting this test error on darwin:

failures:

---- test_clipboard::clipboard_success stdout ----
thread 'test_clipboard::clipboard_success' panicked at tests/test_clipboard.rs:22:42:
called `Result::unwrap()` on an `Err` value: ClipboardNotSupported - "The selected clipboard is not supported with the current system configuration."
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

[itepastra]

It seems to use arboard for it's clipboard, which is made for X11 and thus won't work on darwin. I'll add it as a disabled test on darwin

[uncenter]

Is it worth utilizing the new useFetchCargoVendor option from #349360 to avoid vendoring the Cargo.lock here? I believe we are only vendoring it because of the git deps.

[itepastra]

Like this? @uncenter

[uncenter]

Yep that looks exactly right! Thank you!

[itepastra]

I can't test if it still works correctly on darwin since I don't have a mac

[uncenter]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 356504

---

aarch64-darwin

✅ 1 package built:

• qsv

[uncenter]

It seems to use arboard for it's clipboard, which is made for X11 and thus won't work on darwin. I'll add it as a disabled test on darwin

Interestingly the clipboard feature seems to work, but the test doesn't. Odd!

[itepastra]

In the test it explicitly tries to call a library that is made fox X11, maybe it's real code doesn't do this. Am uncertain

[uncenter]

No worries yeah.

[uncenter]

Wrong button oops 😓

[detroyejr]

This looks good to me and works on nixos! I have a slight preference to sort the skipped tests within each comment section to keep those grouped, but it's not super important.

@uncenter thanks for the cargo lock file suggestion. Wasn't aware of that and I'll be using that in the future!

[uncenter]

Can I get these GitHub actions checks re-run? Looks like they all failed when I accidentally closed this, but they should be passing fine.

[itepastra]

I just rebased the last commit to rerun the tests, didn't change anything

[github-actions]

Successfully created backport PR for release-24.11:

• [Backport release-24.11] qsv: 0.131.1 -> 0.138.0, build simplification #361116