Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions maintainers/maintainer-list.nix
Original file line number Diff line number Diff line change
Expand Up @@ -9459,6 +9459,12 @@
githubId = 3661115;
name = "Ingo Blechschmidt";
};
icedborn = {
email = "github.envenomed@dralias.com";
github = "icedborn";
githubId = 51162078;
name = "IceDBorn";
};
icewind1991 = {
name = "Robin Appelman";
email = "robin@icewind.nl";
Expand Down
52 changes: 52 additions & 0 deletions pkgs/by-name/fa/falkor/package.nix
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
{
lib,
stdenvNoCC,
fetchurl,
electron,
dpkg,
makeWrapper,
commandLineArgs ? "",
}:

stdenvNoCC.mkDerivation (finalAttrs: {
pname = "falkor";
version = "0.0.92";

src = fetchurl {
url = "https://github.com/Team-Falkor/falkor/releases/download/v${finalAttrs.version}/falkor.deb";
hash = "sha256-yDpYu2ehrRQuD29jcyTQla2R2IT1zfBDeWDDRnmqc8Y=";
};

nativeBuildInputs = [
makeWrapper
dpkg
];

installPhase = ''
runHook preInstall

mkdir -p $out/bin
mv usr/share $out/share
mkdir -p $out/share/falkor
sed -i "s|Exec=.*|Exec=falkor|" $out/share/applications/*.desktop
mv opt/falkor/{resources,resources.pak,locales} $out/share/falkor

makeWrapper ${lib.getExe electron} $out/bin/falkor \
--argv0 "falkor" \
--add-flags "$out/share/falkor/resources/app.asar" \
--add-flags ${lib.escapeShellArg commandLineArgs}

runHook postInstall
'';

meta = {
description = "Electron-based gaming hub";
homepage = "https://github.com/Team-Falkor/falkor";
license = with lib.licenses; [ mit ];
maintainers = with lib.maintainers; [ icedborn ];
platforms = [ "x86_64-linux" ];
hydraPlatforms = [ ];
sourceProvenance = [ lib.sourceTypes.binaryNativeCode ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set hydraPlatforms = [ ]; here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JohnRTitor , why was this needed? Is this here to avoid caching the package? And if yes, why?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is to put a light load on nix cache. These packages are not source builds, so it's safe to let them build locally.

This is not required persay, but good practice.

mainProgram = "falkor";
};
})