Skip to content

rustPlatform.fetchCargoVendor: decrease concurrency#356821

Closed
TomaSajt wants to merge 1 commit intoNixOS:masterfrom
TomaSajt:fetchcargovendor-decrease-concurrency
Closed

rustPlatform.fetchCargoVendor: decrease concurrency#356821
TomaSajt wants to merge 1 commit intoNixOS:masterfrom
TomaSajt:fetchcargovendor-decrease-concurrency

Conversation

@TomaSajt
Copy link
Contributor

Related PR: #356539

fetchCargoVendor had very high concurrency limits. Decreased it to 5 jobs max. Also, disabled concurrent fetching of git stuff, since that seemed to be the most flaky in #356539

This change doesn't impact the download time by much, since AFAICT we were limited by the network bandwidth anyways.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. label Nov 17, 2024
@nix-owners nix-owners bot requested review from figsoda, winterqt and zowoq November 17, 2024 22:08
@TomaSajt TomaSajt requested a review from JohnRTitor November 17, 2024 22:23
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 18, 2024
@JohnRTitor
Copy link
Member

Merged as part of #356539

@TomaSajt TomaSajt deleted the fetchcargovendor-decrease-concurrency branch January 20, 2026 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants