[24.05] antares: 0.7.28 -> 0.7.29, modernize; remove electron override#353884
Merged
Scrumplex merged 6 commits intoNixOS:release-24.05from Nov 7, 2024
Merged
Conversation
(cherry picked from commit d918a8a)
(cherry picked from commit 4fec5df)
(cherry picked from commit a89407b)
(cherry picked from commit 2207360)
As far as I'm concerned all (currently) available Electron versions are supported, so we can remove the override. Should an issue arise, the override can be added back. (cherry picked from commit eef5536)
21 tasks
hatch01
approved these changes
Nov 5, 2024
ofborg
bot
added
10.rebuild-darwin: 1-10
hatch01
approved these changes
Nov 6, 2024
wegank
added
the
12.approved-by: package-maintainer
Scrumplex
approved these changes
Nov 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
Manual backports of #350627 #349806 #351513
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.