Skip to content

Comments

[24.05] electron_30-bin: mark as insecure because it's EOL, electron-source.electron_30: remove as it's EOL#352689

Merged
emilazy merged 2 commits intoNixOS:release-24.05from
teutat3s:backport-350549-to-release-24.05
Nov 7, 2024
Merged

[24.05] electron_30-bin: mark as insecure because it's EOL, electron-source.electron_30: remove as it's EOL#352689
emilazy merged 2 commits intoNixOS:release-24.05from
teutat3s:backport-350549-to-release-24.05

Conversation

@teutat3s
Copy link
Member

@teutat3s teutat3s commented Oct 31, 2024

Depends on electron version bumps / backports to 24.05 for:

Things done

Manual backport of #350549

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 1, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 1, 2024
@teutat3s teutat3s added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Nov 5, 2024
@teutat3s teutat3s force-pushed the backport-350549-to-release-24.05 branch from 70827aa to eb0fa85 Compare November 5, 2024 20:39
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 5, 2024
@Bot-wxt1221
Copy link
Member

Nothing against me. Bilibili should be kept on electron-30 because it can't work in higher version. Anyway, bilibili is unfree software and won't influence hydra.

@emilazy emilazy merged commit 023bc62 into NixOS:release-24.05 Nov 7, 2024
@teutat3s teutat3s deleted the backport-350549-to-release-24.05 branch November 7, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants