Skip to content

antares: 0.7.28 -> 0.7.29#349806

Merged
marcusramberg merged 2 commits intoNixOS:masterfrom
hatch01:antares
Oct 20, 2024
Merged

antares: 0.7.28 -> 0.7.29#349806
marcusramberg merged 2 commits intoNixOS:masterfrom
hatch01:antares

Conversation

@hatch01
Copy link
Contributor

@hatch01 hatch01 commented Oct 19, 2024

Things done

update antares and add .desktop file which was missing

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@hatch01 hatch01 marked this pull request as ready for review October 19, 2024 15:35
Copy link
Member

@JohnRTitor JohnRTitor Oct 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point I would just use makeDesktopItem to create the desktop file and use copyDesktopItems hook to copy it automatically.

Docs are here: https://noogle.dev/f/pkgs/makeDesktopItem
An example:

desktopItems = [
(makeDesktopItem {
name = "Nexuiz";
exec = "nexuiz";
icon = "nexuiz";
desktopName = "Nexuiz";
comment = "A free first-person shooter video game developed and published by Alientrap";
categories = [ "Game" "ActionGame" ];
})
];

Copy link
Contributor Author

@hatch01 hatch01 Oct 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's done in my last force push

@JohnRTitor JohnRTitor changed the title Antares antares: 0.7.28 -> 0.7.29 Oct 19, 2024
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 19, 2024
@marcusramberg
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 349806


aarch64-darwin

✅ 1 package built:
  • antares

Copy link
Contributor

@marcusramberg marcusramberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants