odoo: fix tests and update to 18.0#346397
Conversation
github-actions
bot
added
the
6.topic: python
ofborg
bot
added
10.rebuild-darwin: 1-10
phanirithvij
force-pushed
the
odoo-fix-tests
branch
from
83933e7 to
767ad1f
Compare
ofborg
bot
added
the
2.status: merge conflict
siriobalmelli
left a comment
siriobalmelli
left a comment
There was a problem hiding this comment.
I get a merge conflict with master:
Auto-merging pkgs/by-name/od/odoo15/package.nix
CONFLICT (content): Merge conflict in pkgs/by-name/od/odoo15/package.nix
Auto-merging pkgs/development/python-modules/aiohttp/default.nix
Automatic merge failed; fix conflicts and then commit the result.
767ad1f to
ee07757
Compare
ofborg
bot
removed
the
2.status: merge conflict
|
fixed the conflict, try again |
|
I tried this yesterday (before the newest changes) by cherry-picking the commits and applying them on master. It pretty much worked, Odoo 17 was functional, although some smaller features of it weren't working (like QR code generation), but I believe these weren't working in the past either. From my point of view, this fixes the issues of the existing package, so thank you! |
... still running nixpkgs-review ... 🔢 |
|
Result of 2 packages failed to build:
|
|
I don't think the PR needs to target staging. |
That might explain how long it's taking me to build everything: 
|
|
Your rebuild is taking so long because you are targeting staging which has almost no cache. There is no reason to target staging because the rebuild count is almost nothing. |
|
Result of 10 packages failed to build:
|
phanirithvij
force-pushed
the
odoo-fix-tests
branch
from
ee07757 to
91a84a4
Compare
github-actions
bot
added
6.topic: nixos
github-actions
bot
removed
6.topic: nixos
|
Seems like odoo has dropped 15.0 for their docker images and released 18 as well, see https://github.com/odoo/docker and https://github.com/docker-library/docs/tree/master/odoo
Should we remove odoo 15 or still keep it? after ❯ echo odoo{15,16,17,} | xargs -n1 nix-build --no-out-link -A
/nix/store/1d5fl9ki4jzjcnl0z8jvkvar9r6hd6kx-odoo-15.0.20241010
/nix/store/cnfhfq4axq2jchifx5lhalhnlpicap3y-odoo-16.0.20241010
/nix/store/0l9vsxsvkyw4w5mapl5rfxwkb7bxbjb1-odoo-17.0.20241010
/nix/store/8i1ybfms4n9i5af9fpnhx6x4l8szkaxh-odoo-18.0.20241010
❯ echo nixosTests.odoo{15,16,17,} | xargs -n1 nix-build --no-out-link -A
/nix/store/clc8pdnifl3hbqqma2wkw7rbm0lawfli-vm-test-run-odoo
/nix/store/1n8j55q0c8rmy17wq5vc0dgn8g09xqb8-vm-test-run-odoo
/nix/store/864fffbpjzfd3r02r2d7ns53l88phx1p-vm-test-run-odoo
/nix/store/dfnqjljyzy56jsp87w6hp0s9qb6hvvfy-vm-test-run-odooEDIT: never mind, still WIP since symlinks not allowed for upper directory for pkgs/by-name, I'll see what I can do to avoid code duplication. |
ofborg
bot
added
10.rebuild-linux: 1-10
|
|
I tried Edit: works with ~30GB swap. nix-build command takes that much ram? |
phanirithvij
force-pushed
the
odoo-fix-tests
branch
from
4b3cebf to
91a08e7
Compare
|
This is ready, but the update scripts are duplicated, since the pkgs/by-name doesn't allow accessing files outside the tree. #292214 Can everyone test it, try to use odoo18 (if possible older versions too) for a few days and report any breakages here. I hope to get this in before 24.11 freeze. (~ 1 week) NOTE: odoo15 will be dropped after 24.11 release. |
phanirithvij
changed the title
Signed-off-by: phanirithvij <phanirithvij2000@gmail.com>
Co-authored-by: Robert Schütz <github@dotlambda.de> Signed-off-by: phanirithvij <phanirithvij2000@gmail.com>
Signed-off-by: phanirithvij <phanirithvij2000@gmail.com>
Signed-off-by: phanirithvij <phanirithvij2000@gmail.com>
Signed-off-by: phanirithvij <phanirithvij2000@gmail.com>
Signed-off-by: phanirithvij <phanirithvij2000@gmail.com>
phanirithvij
force-pushed
the
odoo-fix-tests
branch
from
91a08e7 to
d48355b
Compare
|
|
Any objections to merge? Would merge in a few days |
|
|
LGTM; I'll circle back to the aarch64-linux builds failures later as needed. |
|
Cross compilation works tho $ echo pkgsCross.aarch64-multiplatform.odoo{15,16,17,} | xargs -n1 nix build -f . --print-out-paths
/nix/store/7m2j0svg34vjnhqm8gyb21l3fz9fyyjm-odoo-15.0.20241010-aarch64-unknown-linux-gnu
/nix/store/68jbpcb3620kg5cw338zwbvax5yjzqnh-odoo-16.0.20241010-aarch64-unknown-linux-gnu
/nix/store/x0wq3s1dfbmwhgn519jw3mhxgizcmyh7-odoo-17.0.20241010-aarch64-unknown-linux-gnu
/nix/store/gagv0a46hbw8lg639y9fx0djjl67cksh-odoo-18.0.20241010-aarch64-unknown-linux-gnu |
6 participants
redo #344173
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)