Skip to content

python310Packages.websockets: disable failing test#348544

Closed
mweinelt wants to merge 2 commits intoNixOS:masterfrom
mweinelt:websockets-3.10
Closed

python310Packages.websockets: disable failing test#348544
mweinelt wants to merge 2 commits intoNixOS:masterfrom
mweinelt:websockets-3.10

Conversation

@mweinelt
Copy link
Member

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Oct 14, 2024
@mweinelt
Copy link
Member Author

Still failing in aiohttp, no energy left to resolve this.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 348544


x86_64-linux

❌ 8 packages failed to build:
  • odoo
  • odoo.dist
  • odoo16
  • odoo16.dist
  • pytrainer
  • pytrainer.dist
  • stig
  • stig.dist
✅ 2 packages built:
  • circus
  • circus.dist

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 14, 2024
@phanirithvij
Copy link
Member

I've cherry-picked your commits into my odoo pr #346397
and aiohttp test breakage fix as well.

thanks for the quick fixes.

@mweinelt mweinelt closed this Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants