Conversation
dotlambda
left a comment
There was a problem hiding this comment.
Can we put the aiohttp, flake8, and pyflakes changes in a separate PR?
odoo test requires these to pass, how does having these in a separate pr help? |
How so? The packages build just fine on master. |
69abfda to
3b5720d
Compare
|
odoo requires 310.furl, 310.aiohttp, 310.websockets
in master (this pr's commits)
flake8, pyflakes are broken for pypy and 313 so I will make a separate pr. |
3b5720d to
e8a38ca
Compare
|
I don't know if any functionality breaks in odoo during runtime due to the changes I made in odoo15 and odoo16. can someone who uses odoo test the binaries/service are working and have no obvious regressions? @mkg20001 @siriobalmelli ? the basic nixos tests pass for all versions. $ echo nixosTests.odoo{,15,16} | xargs -n1 nix-build --no-out-link -A
/nix/store/q07i71157l7v00bq51rb4acilx334hip-vm-test-run-odoo
/nix/store/1rh0y82rxf27cwifily41h018bq93hkb-vm-test-run-odoo
/nix/store/mkdr4w9wmv4zccbvwzggp8j7067mzsbl-vm-test-run-odoo |
|
@phanirithvij I currently don't have any odoo install to test, but since the tests also check if the odoo instance responds to requests after starting it also checks (a bit) of the runtime stuff. Shouldn't cause any big breakage. |
|
But others should feel free to test and report. Let's give it a day or two. |
…lab: add missing dependency cleanvision (NixOS#344816)
Signed-off-by: phanirithvij <phanirithvij2000@gmail.com>
Co-authored-by: Robert Schütz <github@dotlambda.de> odoo: update, fix update script Signed-off-by: phanirithvij <phanirithvij2000@gmail.com>
Signed-off-by: phanirithvij <phanirithvij2000@gmail.com>
Signed-off-by: phanirithvij <phanirithvij2000@gmail.com>
e8a38ca to
99f5273
Compare
|
I seem to have messed this up, apologies, will open a new one. |
|
@phanirithvij for the record I really appreciate your help getting odoo into shape. I have been traveling and haven't had a chance to spin up a test instance to validate, but should have time to pitch in and help get this sorted towards the beginning of next week. Please tag me when you open a new PR or re-open this one 🙏 |
Description of changes
fix odoo package tests. (also fixes furl tests #320020 (comment))
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.
cc: @mweinelt