Skip to content

cp2k: cleanup, format, move to pkgs/by-name#344847

Merged
markuskowa merged 4 commits intoNixOS:masterfrom
markuskowa:fix-cp2k
Sep 27, 2024
Merged

cp2k: cleanup, format, move to pkgs/by-name#344847
markuskowa merged 4 commits intoNixOS:masterfrom
markuskowa:fix-cp2k

Conversation

@markuskowa
Copy link
Member

Description of changes

Cleanup work.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@sheepforce sheepforce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Urgh, not sure if I'm a fan of what nixfmt is doing (my Haskell heart is bleeding seeing this comma style), but otherwise LGTM 😄

@markuskowa
Copy link
Member Author

Urgh, not sure if I'm a fan of what nixfmt is doing (my Haskell heart is bleeding seeing this comma style), but otherwise LGTM 😄

Me neither. Some things just look strange, but that is what the RFC decided.

@ofborg ofborg bot requested a review from sheepforce September 27, 2024 10:02
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Sep 27, 2024
@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Sep 27, 2024
@markuskowa markuskowa merged commit 539ef5a into NixOS:master Sep 27, 2024
@markuskowa markuskowa deleted the fix-cp2k branch September 27, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants