vimPlugins.render-markdown-nvim: remove unneeded nvim-treesitter dependency#344143
Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom Sep 24, 2024
Merged
vimPlugins.render-markdown-nvim: remove unneeded nvim-treesitter dependency#344143Aleksanaa merged 1 commit intoNixOS:masterfrom
Aleksanaa merged 1 commit intoNixOS:masterfrom
Conversation
ofborg
bot
added
10.rebuild-darwin: 1-10
Contributor
Author
|
Aleksanaa
changed the title
PerchunPak
reviewed
Sep 24, 2024
| }; | ||
|
|
||
| render-markdown-nvim = super.render-markdown-nvim.overrideAttrs { | ||
| dependencies = with self; [ nvim-treesitter ]; |
Member
There was a problem hiding this comment.
Shouldn't this be nvim-treesitter-parsers.markdown nvim-treesitter-parsers.latex?
Contributor
Author
There was a problem hiding this comment.
I think that this wouldn't be enough to get the parsers "installed" properly.
Member
There was a problem hiding this comment.
nvim-treesitter.withPlugins just adds those to nvim-treesitter.passthru.dependencies, so it should be enough
Contributor
Author
There was a problem hiding this comment.
Oh, I didn't know.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
#343557 (comment)
cc @mrcjkb
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.